RefCounted types should not have public destructors, net/ edition

net/base/network_change_notifier.h

Index: net/base/network_change_notifier.h
diff --git a/net/base/network_change_notifier.h b/net/base/network_change_notifier.h
index 477d1f718cd6114710dd1b0ea5e374273025061e..030d7adbfad28ab32fc3bc1e55b60849702919f7 100644
--- a/net/base/network_change_notifier.h
+++ b/net/base/network_change_notifier.h
@@ -40,14 +40,13 @@ class NET_EXPORT NetworkChangeNotifier {
 
   class NET_EXPORT IPAddressObserver {
    public:
-    virtual ~IPAddressObserver() {}
-
     // Will be called when the IP address of the primary interface changes.
     // This includes when the primary interface itself changes.
     virtual void OnIPAddressChanged() = 0;
 
    protected:
     IPAddressObserver() {}
+    virtual ~IPAddressObserver() {}
 
    private:
     DISALLOW_COPY_AND_ASSIGN(IPAddressObserver);
@@ -55,8 +54,6 @@ class NET_EXPORT NetworkChangeNotifier {
 
   class NET_EXPORT OnlineStateObserver {
    public:
-    virtual ~OnlineStateObserver() {}
-
     // Will be called when the online state of the system may have changed.
     // See NetworkChangeNotifier::IsOffline() for important caveats about
     // the unreliability of this signal.
@@ -64,6 +61,7 @@ class NET_EXPORT NetworkChangeNotifier {
 
    protected:
     OnlineStateObserver() {}
+    virtual ~OnlineStateObserver() {}

[willchan no longer on Chromium, 2012/05/21 14:31:08]

These types aren't refcounted, why are their destructors being made protected?

 
    private:
     DISALLOW_COPY_AND_ASSIGN(OnlineStateObserver);
@@ -71,14 +69,13 @@ class NET_EXPORT NetworkChangeNotifier {
 
   class NET_EXPORT DNSObserver {
    public:
-    virtual ~DNSObserver() {}
-
     // Will be called when the DNS settings of the system may have changed.
     // The flags set in |detail| provide the specific set of changes.
     virtual void OnDNSChanged(unsigned detail) = 0;
 
    protected:
     DNSObserver() {}
+    virtual ~DNSObserver() {}
 
    private:
     DISALLOW_COPY_AND_ASSIGN(DNSObserver);