chrome/browser/io_thread.h - Issue 10417002: RefCounted types should not have public destructors, net/ edition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/io_thread.h

Issue 10417002: RefCounted types should not have public destructors, net/ edition (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/io_thread.h

diff --git a/chrome/browser/io_thread.h b/chrome/browser/io_thread.h

index 1390c2cf687dca0357e2952cb05f07f3682c96f5..e74f43be1d27e605b61b0326ff7b1fef5f65c28d 100644

--- a/chrome/browser/io_thread.h

+++ b/chrome/browser/io_thread.h

@@ -184,8 +184,8 @@ class IOThread : public content::BrowserThreadDelegate {

Globals* globals_;

// Observer that logs network changes to the ChromeNetLog.

- scoped_ptr<net::NetworkChangeNotifier::IPAddressObserver>

- network_change_observer_;

+ class LoggingNetworkChangeObserver;

+ scoped_ptr<LoggingNetworkChangeObserver> network_change_observer_;

willchan no longer on Chromium 2012/05/21 14:31:08 I don't mind, but was this change necessary? Do we

BooleanPrefMember system_enable_referrers_;

« no previous file with comments | « no previous file | chrome/browser/io_thread.cc » ('j') | net/base/network_change_notifier.h » ('J')