Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Unified Diff: net/socket_stream/socket_stream.h

Issue 10417002: RefCounted types should not have public destructors, net/ edition (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket_stream/socket_stream.h
diff --git a/net/socket_stream/socket_stream.h b/net/socket_stream/socket_stream.h
index 2fa3683775adccf91561c33c278acd75e3110d7f..cb4ecf43c386326f46599acd1c50172cd360dea3 100644
--- a/net/socket_stream/socket_stream.h
+++ b/net/socket_stream/socket_stream.h
@@ -59,8 +59,6 @@ class NET_EXPORT SocketStream
class NET_EXPORT Delegate {
public:
- virtual ~Delegate() {}
-
virtual int OnStartOpenConnection(SocketStream* socket,
const CompletionCallback& callback) {
return OK;
@@ -121,6 +119,9 @@ class NET_EXPORT SocketStream
CookieOptions* options) {
return true;
}
+
+ protected:
+ virtual ~Delegate() {}
};
SocketStream(const GURL& url, Delegate* delegate);

Powered by Google App Engine
This is Rietveld 408576698