RefCounted types should not have public destructors

content/browser/download/download_resource_handler.cc

Index: content/browser/download/download_resource_handler.cc
diff --git a/content/browser/download/download_resource_handler.cc b/content/browser/download/download_resource_handler.cc
index c3e47fe2e8f76320c770249aae717d3bbfe38512..818d94563ea62fa2cd5746fbd088519246c5c10b 100644
--- a/content/browser/download/download_resource_handler.cc
+++ b/content/browser/download/download_resource_handler.cc
@@ -105,7 +105,7 @@ bool DownloadResourceHandler::OnResponseStarted(
   request_->GetResponseHeaderByName("content-disposition",
                                     &content_disposition);
   set_content_disposition(content_disposition);
-  set_content_length(response->content_length);
+  set_content_length(response->data.content_length);

[darin (slow to review), 2012/05/22 18:01:31]

yuck, the extra "data." is quite unfortunate.

 
   const ResourceRequestInfoImpl* request_info =
       ResourceRequestInfoImpl::ForRequest(request_);
@@ -123,7 +123,7 @@ bool DownloadResourceHandler::OnResponseStarted(
   info->state = DownloadItem::IN_PROGRESS;
   info->has_user_gesture = request_info->has_user_gesture();
   info->content_disposition = content_disposition_;
-  info->mime_type = response->mime_type;
+  info->mime_type = response->data.mime_type;
   info->remote_address = request_->GetSocketAddress().host();
   download_stats::RecordDownloadMimeType(info->mime_type);
 
@@ -142,15 +142,14 @@ bool DownloadResourceHandler::OnResponseStarted(
   }
 
   std::string content_type_header;
-  if (!response->headers ||
-      !response->headers->GetMimeType(&content_type_header))
+  if (!response->data.headers ||
+      !response->data.headers->GetMimeType(&content_type_header))
     content_type_header = "";
   info->original_mime_type = content_type_header;
 
-  if (!response->headers ||
-      !response->headers->EnumerateHeader(NULL,
-                                          "Accept-Ranges",
-                                          &accept_ranges_)) {
+  if (!response->data.headers ||
+      !response->data.headers->EnumerateHeader(
+          NULL, "Accept-Ranges", &accept_ranges_)) {
     accept_ranges_ = "";
   }