RefCounted types should not have public destructors

content/public/common/resource_response.h

Index: content/public/common/resource_response.h
diff --git a/content/public/common/resource_response.h b/content/public/common/resource_response.h
index 9a8e3a8a85e3afba4b03bff4d706a5d78accbe01..130eca84cea56fbe71b69d66f4f0f48ffafa5cbf 100644
--- a/content/public/common/resource_response.h
+++ b/content/public/common/resource_response.h
@@ -39,13 +39,10 @@ struct SyncLoadResult : ResourceResponseHead {
 };
 
 // Simple wrapper that refcounts ResourceResponseHead.
-struct CONTENT_EXPORT ResourceResponse
-    : public NON_EXPORTED_BASE(ResourceResponseHead),
-      public base::RefCounted<ResourceResponse> {
-
- private:
-  friend class base::RefCounted<ResourceResponse>;
-
+// Inherited, rather than typedef'd, to allow forward declarations.
+class CONTENT_EXPORT ResourceResponse

[jam, 2012/05/21 15:18:43]

please keep this as a struct. for the content api, we only want either structs
or classes that are intefaces in the public dir

[darin (slow to review), 2012/05/22 18:01:31]

+1

This should be a struct.  What problem was the old code causing?

+    : public base::RefCountedData<ResourceResponseHead> {
+ protected:
   ~ResourceResponse() {}
 };