Issue 10414010: PPAPI/NaCl: Partial revert of r137751 to fix WebKit build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10414010: PPAPI/NaCl: Partial revert of r137751 to fix WebKit build (Closed)

Created:
8 years, 7 months ago by dmichael (off chromium)

Modified:
8 years, 7 months ago

Reviewers:
bbudge

CC:
chromium-reviews, bbudge, jochen (gone - plz use gerrit), Mark Seaborn

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

PPAPI/NaCl: Partial revert of r137751 to fix WebKit build This simply removes the conditional include. I don't think there's a way to get gyp to not _parse_ a file behind a conditional. I need to find a new home for this include in a gyp file that WebKit doesn't include. TBR=bbudge BUG=116317 TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137975

Patch Set 1 #

Patch Set 2 : Just partial revert for now :( #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -5 lines)			Patch
	M	ppapi/ppapi.gyp	View		1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

dmichael (off chromium)

Landed TBR. I'll need to circle back and find a more appropriate fix, but this ...

8 years, 7 months ago (2012-05-18 22:48:05 UTC) #1

lgtm

Expand Messages | Collapse Messages