Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Side by Side Diff: ppapi/ppapi.gyp

Issue 10414010: PPAPI/NaCl: Partial revert of r137751 to fix WebKit build (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Just partial revert for now :( Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # This is the "public" ppapi.gyp file, which must have dependencies on the 5 # This is the "public" ppapi.gyp file, which must have dependencies on the
6 # redistributable portions of PPAPI only. This prevents circular dependencies 6 # redistributable portions of PPAPI only. This prevents circular dependencies
7 # in the .gyp files (since ppapi_internal depends on parts of Chrome). 7 # in the .gyp files (since ppapi_internal depends on parts of Chrome).
8 8
9 { 9 {
10 'conditions': [
11 ['disable_nacl==0 and build_ppapi_ipc_proxy_untrusted==1', {
12 'includes': ['ppapi_proxy_untrusted.gypi'],
13 }],
14 ],
15 'variables': { 10 'variables': {
16 'chromium_code': 1, # Use higher warning level. 11 'chromium_code': 1, # Use higher warning level.
17 }, 12 },
18 'target_defaults': { 13 'target_defaults': {
19 'conditions': [ 14 'conditions': [
20 # Linux shared libraries should always be built -fPIC. 15 # Linux shared libraries should always be built -fPIC.
21 # 16 #
22 # TODO(ajwong): For internal pepper plugins, which are statically linked 17 # TODO(ajwong): For internal pepper plugins, which are statically linked
23 # into chrome, do we want to build w/o -fPIC? If so, how can we express 18 # into chrome, do we want to build w/o -fPIC? If so, how can we express
24 # that in the build system? 19 # that in the build system?
25 ['os_posix == 1 and OS != "mac"', { 20 ['os_posix == 1 and OS != "mac"', {
26 'cflags': ['-fPIC', '-fvisibility=hidden'], 21 'cflags': ['-fPIC', '-fvisibility=hidden'],
27 22
28 # This is needed to make the Linux shlib build happy. Without this, 23 # This is needed to make the Linux shlib build happy. Without this,
29 # -fvisibility=hidden gets stripped by the exclusion in common.gypi 24 # -fvisibility=hidden gets stripped by the exclusion in common.gypi
30 # that is triggered when a shared library build is specified. 25 # that is triggered when a shared library build is specified.
31 'cflags/': [['include', '^-fvisibility=hidden$']], 26 'cflags/': [['include', '^-fvisibility=hidden$']],
32 }], 27 }],
33 ], 28 ],
34 }, 29 },
35 'includes': [ 30 'includes': [
36 'ppapi_sources.gypi', 31 'ppapi_sources.gypi',
37 'ppapi_cpp.gypi', 32 'ppapi_cpp.gypi',
38 'ppapi_gl.gypi', 33 'ppapi_gl.gypi',
39 ], 34 ],
40 } 35 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698