Upstream implementation for embedded video for WebMediaPlayerAndroid

content/public/renderer/render_view.h

Index: content/public/renderer/render_view.h
diff --git a/content/public/renderer/render_view.h b/content/public/renderer/render_view.h
index 7d291a49ad9465c8fcf1f79b8511d9450ee82e82..7c8227667997b84e12becd26519d0357ca855d6c 100644
--- a/content/public/renderer/render_view.h
+++ b/content/public/renderer/render_view.h
@@ -16,6 +16,12 @@ namespace webkit_glue {
 struct WebPreferences;
 }
 
+#if defined(OS_ANDROID)
+namespace webkit_media {
+class WebMediaPlayerManagerAndroid;
+}
+#endif
+
 namespace WebKit {
 class WebFrame;
 class WebNode;
@@ -130,6 +136,12 @@ class CONTENT_EXPORT RenderView : public IPC::Message::Sender {
       WebKit::WebFrame* frame,
       const WebKit::WebURLRequest& request,
       WebKit::WebNavigationPolicy policy) = 0;
+
+#if defined(OS_ANDROID)
+  // Returns the manager for all the WebMediaPlayers.
+  virtual webkit_media::WebMediaPlayerManagerAndroid*
+      GetWebMediaPlayerManager() = 0;

[jam, 2012/05/21 15:39:13]

does this need to be in the public API? i.e. who's going to be calling this
function, code in src/content or src/chrome?

[qinmin, 2012/05/21 16:42:39]

Not necessarily. We call this in content/renderer/render_thread_impl.cc.
The caller VideoSurfaceVisitor is inherited from content::RenderViewVisitor, and
calling this function in the inherited visit() function. Because visit() takes
an RenderView* param, so we expose this for convenience.

Alternatively, I can use render_view->GetWebView() and then call
RenderViewImpl::FromWebView() to get the pointer to RenderViewImpl. I will
change the code to do this. 

On 2012/05/21 15:39:13, John Abd-El-Malek wrote:

+#endif
 };
 
 }  // namespace content