Upstream implementation for embedded video for WebMediaPlayerAndroid

content/public/renderer/render_view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_RENDERER_RENDER_VIEW_H_
 #define CONTENT_PUBLIC_RENDERER_RENDER_VIEW_H_
 
 #include "base/basictypes.h"
 #include "content/common/content_export.h"
 #include "ipc/ipc_message.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebNavigationPolicy.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebPageVisibilityState.h"
 #include "ui/gfx/native_widget_types.h"
 
 namespace webkit_glue {
 struct WebPreferences;
 }
 
+#if defined(OS_ANDROID)
+namespace webkit_media {
+class WebMediaPlayerManagerAndroid;
+}
+#endif
+
 namespace WebKit {
 class WebFrame;
 class WebNode;
 class WebPlugin;
 class WebString;
 class WebURLRequest;
 class WebView;
 struct WebContextMenuData;
 struct WebPluginParams;
 }
@@ skipping 94 matching lines @@
   // Displays a modal alert dialog containing the given message.  Returns
   // once the user dismisses the dialog.
   virtual void RunModalAlertDialog(WebKit::WebFrame* frame,
                                    const WebKit::WebString& message) = 0;
 
   // The client should handle the navigation externally.
   virtual void LoadURLExternally(
       WebKit::WebFrame* frame,
       const WebKit::WebURLRequest& request,
       WebKit::WebNavigationPolicy policy) = 0;
+
+#if defined(OS_ANDROID)
+  // Returns the manager for all the WebMediaPlayers.
+  virtual webkit_media::WebMediaPlayerManagerAndroid*
+      GetWebMediaPlayerManager() = 0;

[jam, 2012/05/21 15:39:13]

does this need to be in the public API? i.e. who's going to be calling this
function, code in src/content or src/chrome?

[qinmin, 2012/05/21 16:42:39]

Not necessarily. We call this in content/renderer/render_thread_impl.cc.
The caller VideoSurfaceVisitor is inherited from content::RenderViewVisitor, and
calling this function in the inherited visit() function. Because visit() takes
an RenderView* param, so we expose this for convenience.

Alternatively, I can use render_view->GetWebView() and then call
RenderViewImpl::FromWebView() to get the pointer to RenderViewImpl. I will
change the code to do this. 

On 2012/05/21 15:39:13, John Abd-El-Malek wrote:

+#endif
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_RENDERER_RENDER_VIEW_H_