Fix bug in combination of bounded and exact types.

Fix bug in combination of bounded and exact types.

TEST=language/switch_this_test.dart

Committed: https://code.google.com/p/dart/source/detail?r=7944

[ngeoffray, 2012-05-23 14:09:45]

https://chromiumcodereview.appspot.com/10411094/diff/2001/lib/compiler/implem...
File lib/compiler/implementation/ssa/types.dart (right):

https://chromiumcodereview.appspot.com/10411094/diff/2001/lib/compiler/implem...
lib/compiler/implementation/ssa/types.dart:653: if (this.type === bounded.type)
return other;
This is OK for the union but not for the intersection. Maybe you should get rid
of combine and implement union/intersection for HBoundedType and HExactType.

https://chromiumcodereview.appspot.com/10411094/diff/2001/tests/language/swit...
File tests/language/switch_this_test.dart (right):

https://chromiumcodereview.appspot.com/10411094/diff/2001/tests/language/swit...
tests/language/switch_this_test.dart:4: // Test that a new scope is introduced
for each switch case.
Update comment.

[karlklose, 2012-05-24 12:37:49]

PTAL.

http://codereview.chromium.org/10411094/diff/2001/lib/compiler/implementation...
File lib/compiler/implementation/ssa/types.dart (right):

http://codereview.chromium.org/10411094/diff/2001/lib/compiler/implementation...
lib/compiler/implementation/ssa/types.dart:653: if (this.type === bounded.type)
return other;
On 2012/05/23 14:09:45, ngeoffray wrote:
> This is OK for the union but not for the intersection. Maybe you should get
rid
> of combine and implement union/intersection for HBoundedType and HExactType.

Done.

http://codereview.chromium.org/10411094/diff/2001/tests/language/switch_this_...
File tests/language/switch_this_test.dart (right):

http://codereview.chromium.org/10411094/diff/2001/tests/language/switch_this_...
tests/language/switch_this_test.dart:4: // Test that a new scope is introduced
for each switch case.
On 2012/05/23 14:09:45, ngeoffray wrote:
> Update comment.

Done.

[ngeoffray, 2012-05-24 12:44:05]

LGTM!