Build AVC decoder configuration record

content/common/gpu/media/h264_parser.cc

Index: content/common/gpu/media/h264_parser.cc
diff --git a/content/common/gpu/media/h264_parser.cc b/content/common/gpu/media/h264_parser.cc
index ebed3f2bfcbdef5ff5f05945b2d92c6219b790fd..ef73c5c9fa858065ecedd88e71adc88ecad64f47 100644
--- a/content/common/gpu/media/h264_parser.cc
+++ b/content/common/gpu/media/h264_parser.cc
@@ -647,7 +647,6 @@ static void FillDefaultSeqScalingLists(H264SPS* sps) {
 
 H264Parser::Result H264Parser::ParseSPS(int* sps_id) {
   // See 7.4.2.1.
-  int data;
   Result res;
 
   *sps_id = -1;
@@ -655,8 +654,7 @@ H264Parser::Result H264Parser::ParseSPS(int* sps_id) {
   scoped_ptr<H264SPS> sps(new H264SPS());
 
   READ_BITS_OR_RETURN(8, &sps->profile_idc);
-  // Skip constraint_setx_flag and reserved flags.
-  READ_BITS_OR_RETURN(8, &data);
+  READ_BITS_OR_RETURN(8, &sps->constraint_setx_flag);

[Pawel Osciak, 2012/05/30 00:28:40]

There are only 6 bits of flags, the last 2 bits are reserved. I think this
should be 6 bit and you should add an additional read of reserved 2 bits. Just
to prevent possible confusion in the future.

[sail, 2012/06/02 21:05:49]

Done.
It looks like the last 4 bytes are supposed to be reserved.

   READ_BITS_OR_RETURN(8, &sps->level_idc);
   READ_UE_OR_RETURN(&sps->seq_parameter_set_id);
   TRUE_OR_RETURN(sps->seq_parameter_set_id < 32);