Build AVC decoder configuration record

content/common/gpu/media/h264_parser.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/logging.h"
 #include "base/stl_util.h"
 #include "content/common/gpu/media/h264_parser.h"
 
 namespace content {
 
@@ skipping 629 matching lines @@
 }
 
 static void FillDefaultSeqScalingLists(H264SPS* sps) {
   // Assumes ints in arrays.
   memset(sps->scaling_list4x4, 16, sizeof(sps->scaling_list4x4));
   memset(sps->scaling_list8x8, 16, sizeof(sps->scaling_list8x8));
 }
 
 H264Parser::Result H264Parser::ParseSPS(int* sps_id) {
   // See 7.4.2.1.
-  int data;
   Result res;
 
   *sps_id = -1;
 
   scoped_ptr<H264SPS> sps(new H264SPS());
 
   READ_BITS_OR_RETURN(8, &sps->profile_idc);
-  // Skip constraint_setx_flag and reserved flags.
-  READ_BITS_OR_RETURN(8, &data);
+  READ_BITS_OR_RETURN(8, &sps->constraint_setx_flag);

[Pawel Osciak, 2012/05/30 00:28:40]

There are only 6 bits of flags, the last 2 bits are reserved. I think this
should be 6 bit and you should add an additional read of reserved 2 bits. Just
to prevent possible confusion in the future.

[sail, 2012/06/02 21:05:49]

Done.
It looks like the last 4 bytes are supposed to be reserved.

   READ_BITS_OR_RETURN(8, &sps->level_idc);
   READ_UE_OR_RETURN(&sps->seq_parameter_set_id);
   TRUE_OR_RETURN(sps->seq_parameter_set_id < 32);
 
   if (sps->profile_idc == 100 || sps->profile_idc == 110 ||
       sps->profile_idc == 122 || sps->profile_idc == 244 ||
       sps->profile_idc ==  44 || sps->profile_idc ==  83 ||
       sps->profile_idc ==  86 || sps->profile_idc == 118 ||
       sps->profile_idc == 128) {
     READ_UE_OR_RETURN(&sps->chroma_format_idc);
@@ skipping 520 matching lines @@
     default:
       DVLOG(4) << "Unsupported SEI message";
       break;
   }
 
   return kOk;
 }
 
 } // namespace content