Type profiler by intercepting 'new' and 'delete' expressions.

base/allocator/type_profiler_control.h

Index: base/allocator/type_profiler_control.h
diff --git a/base/allocator/type_profiler_control.h b/base/allocator/type_profiler_control.h
new file mode 100644
index 0000000000000000000000000000000000000000..4a6a551d27489fa8f60e4178467778f8a859d98c
--- /dev/null
+++ b/base/allocator/type_profiler_control.h
@@ -0,0 +1,29 @@
+// Copyright 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef BASE_ALLOCATOR_TYPE_PROFILER_CONTROL_H_
+#define BASE_ALLOCATOR_TYPE_PROFILER_CONTROL_H_
+
+namespace base {
+namespace type_profiler {
+
+class ProfilingController {

[jar (doing other things), 2012/09/12 00:34:09]

Change name to Controller.

It was bad enough that the "type_profiler" had a function called "StopProfiling"
rather than merely "Stop," but now we have the word "Profile" three times in:

base::typeprofiler::ProfilingController::StopProfiling()

You should also change:
StopProfiling() to Stop()
RestartProfiling() to Restart()

[Dai Mikurube (NOT FULLTIME), 2012/09/12 04:26:27]

Done.

+ public:
+  static void StopProfiling();
+  static bool IsProfiling();
+
+ private:
+  friend class TypeProfilerTest;
+
+  // Is must be used only from allowed unit tests.  Restarting type profiler
+  // is not allowed to simplify the profiler (except for TypeProfilerTest).

[jar (doing other things), 2012/09/12 00:34:09]

Typo in first sentence "Is must be used..."

The second sentence is awkward, and ambiguous.  For instance: Why is this "not
allowed to simplify the profiler?"  Why don't we allow it to simplify the
profiler??

Please change to:
The following is only allowed for use in unit tests. Profiling should never be
restarted in regular use.

[Dai Mikurube (NOT FULLTIME), 2012/09/12 04:26:27]

Done.

+  static void RestartProfiling();
+
+  static bool enable_intercept_;
+};
+
+}  // namespace type_profiler
+}  // namespace base
+
+#endif  // BASE_ALLOCATOR_TYPE_PROFILER_CONTROL_H_