Type profiler by intercepting 'new' and 'delete' expressions.

base/allocator/type_profiler_control.cc

Index: base/allocator/type_profiler_control.cc
diff --git a/base/allocator/type_profiler_control.cc b/base/allocator/type_profiler_control.cc
new file mode 100644
index 0000000000000000000000000000000000000000..1a367cdfa056cb66bbb6dc0a4714d6d65206e705
--- /dev/null
+++ b/base/allocator/type_profiler_control.cc
@@ -0,0 +1,32 @@
+// Copyright 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/allocator/type_profiler_control.h"
+
+namespace base {
+namespace type_profiler {
+
+#if defined(TYPE_PROFILING)
+bool ProfilingController::enable_intercept_ = true;
+#else
+bool ProfilingController::enable_intercept_ = false;
+#endif
+
+// static
+void ProfilingController::StopProfiling() {
+  enable_intercept_ = false;
+}
+
+// static
+bool ProfilingController::IsProfiling() {
+  return enable_intercept_ != 0;

[jar (doing other things), 2012/09/12 00:34:09]

Don't compare a bool to zero.  Just use the bool.

[Dai Mikurube (NOT FULLTIME), 2012/09/12 04:26:27]

Done.

+}
+
+// static
+void ProfilingController::RestartProfiling() {
+  enable_intercept_ = true;

[jar (doing other things), 2012/09/12 00:34:09]

The creation of this function will make it harder for the compiler to realize
this is all dead code when the TYPE_PROFILING macro is undefined.

Add the following to clarify:

namespace {
Instead of having the ifdef around line 10, please use:
#if defined(TYPE_PROFILING)
const bool kTypeProfilingEnabled = true;
#else
const bool kTypeProfilingEnabled = false;
#endif
}  // anonymous namespace.

The above should be place around line 9.

You can then avoid the ifdef on line 10, with:
bool ProfilingController::enable_intercept_ = kTypeProfilingEnabled ;

You can hten modify IsProfiling  to be:

kTypeProfilingEnabled && enable_intercept_;

[Dai Mikurube (NOT FULLTIME), 2012/09/12 04:26:27]

Done.

+}
+
+}  // namespace type_profiler
+}  // namespace base