Issue 10409051: Make standalone Dart VM run on Windows XP

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10409051: Make standalone Dart VM run on Windows XP (Closed)

Created:
8 years, 7 months ago by Søren Gjesse

Modified:
8 years, 7 months ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make standalone Dart VM run on Windows XP Use the function WSAAddressToString for converting an IP address to a string instead of inet_ntop. WSAAddressToString is available on Windows XP. R=ager@google.com BUG=dart:2559 TEST=tests\standalone\io\socket_info_test.dart Committed: https://code.google.com/p/dart/source/detail?r=7797

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed review commetns #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -6 lines)			Patch
	M	runtime/bin/socket_win.cc	View	1	1 chunk	+12 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

lgtm https://chromiumcodereview.appspot.com/10409051/diff/1/runtime/bin/socket_win.cc File runtime/bin/socket_win.cc (right): https://chromiumcodereview.appspot.com/10409051/diff/1/runtime/bin/socket_win.cc#newcode75 runtime/bin/socket_win.cc:75: fprintf(stderr, "Error WSAAddressToString: %d\n", WSAGetLastError()); Return false?

8 years, 7 months ago (2012-05-21 13:24:34 UTC) #2

Søren Gjesse

8 years, 7 months ago (2012-05-21 13:28:57 UTC) #3

http://codereview.chromium.org/10409051/diff/1/runtime/bin/socket_win.cc
File runtime/bin/socket_win.cc (right):

http://codereview.chromium.org/10409051/diff/1/runtime/bin/socket_win.cc#newc...
runtime/bin/socket_win.cc:75: fprintf(stderr, "Error WSAAddressToString: %d\n",
WSAGetLastError());
On 2012/05/21 13:24:34, Mads Ager wrote:
> Return false?

Good catch, thanks.

Expand Messages | Collapse Messages