Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(773)

Unified Diff: content/browser/renderer_host/buffered_resource_handler.cc

Issue 10392111: Use ByteStream in downloads system to decouple source and sink. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Incorporated comments and fixed tests. Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/buffered_resource_handler.cc
diff --git a/content/browser/renderer_host/buffered_resource_handler.cc b/content/browser/renderer_host/buffered_resource_handler.cc
index b0de440f1be276bc8369fa386f3c2ca052be6ebd..0c01f6f93f97de0e1a5444c1afdebbd4d80826fa 100644
--- a/content/browser/renderer_host/buffered_resource_handler.cc
+++ b/content/browser/renderer_host/buffered_resource_handler.cc
@@ -281,8 +281,7 @@ bool BufferedResourceHandler::CompleteResponseStarted(int request_id,
new X509UserCertResourceHandler(request_,
info->GetChildID(),
info->GetRouteID());
- if (!UseAlternateResourceHandler(request_id, x509_cert_handler, defer))
- return false;
+ return UseAlternateResourceHandler(request_id, x509_cert_handler, defer);
benjhayden 2012/05/26 20:42:02 Is it ok to not run next_handler_->OnResponseStart
Randy Smith (Not in Mondays) 2012/05/28 02:51:37 UseAlternateResourceHandler() takes responsibility
} else if (info->allow_download() && ShouldDownload(NULL)) {
// Forward the data to the download thread.
@@ -310,8 +309,7 @@ bool BufferedResourceHandler::CompleteResponseStarted(int request_id,
DownloadSaveInfo(),
DownloadResourceHandler::OnStartedCallback()));
- if (!UseAlternateResourceHandler(request_id, handler, defer))
- return false;
+ return UseAlternateResourceHandler(request_id, handler, defer);
}
if (*defer)

Powered by Google App Engine
This is Rietveld 408576698