Avoid double calling OnResponseStarted from BufferedResourceHandler

Avoid double calling OnResponseStarted from BufferedResourceHandler

BUG=129646
R=darin@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=139295

[Randy Smith (Not in Mondays), 2012-05-25 21:21:15]

Darin: PTAL?  Two notes:
* I did see this in one of my sandboxes, but when I went back to repro I
couldn't because the download resource throttle was always pausing things
anyway.  So I'm a bit confused.  You're welcome to block this until we actually
see it in the wild, or to let it through because it's a real problem we need to
fix by inspection; your call.

* I didn't take your original suggestion because simply conditionalizing the
final call to OnResponseStarted in CompleteResponseStarted on
on_response_started_needed_ fails on non-alterante resource handler (because
on_response_started_needed_ is constructed false).  I could have rewritten the
entire resource handler so that on_response_started_needed_ is always accurate,
but that level of change didn't seem worth it for this level of problem. 
Obviously, let me know if you feel differently.

[darin (slow to review), 2012-05-25 21:24:34]

LGTM

http://codereview.chromium.org/10451023/diff/6002/content/browser/renderer_ho...
File content/browser/renderer_host/buffered_resource_handler.cc (right):

http://codereview.chromium.org/10451023/diff/6002/content/browser/renderer_ho...
content/browser/renderer_host/buffered_resource_handler.cc:285: } else if
(info->allow_download() && ShouldDownload(NULL)) {
thanks to the unconditional return above, you can remove this else.

[Randy Smith (Not in Mondays), 2012-05-28 03:07:02]

Thanks!

http://codereview.chromium.org/10451023/diff/6002/content/browser/renderer_ho...
File content/browser/renderer_host/buffered_resource_handler.cc (right):

http://codereview.chromium.org/10451023/diff/6002/content/browser/renderer_ho...
content/browser/renderer_host/buffered_resource_handler.cc:285: } else if
(info->allow_download() && ShouldDownload(NULL)) {
On 2012/05/25 21:24:34, darin wrote:
> thanks to the unconditional return above, you can remove this else.

Done.

[commit-bot: I haz the power, 2012-05-29 13:58:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rdsmith@chromium.org/10451023/1004

[commit-bot: I haz the power, 2012-05-29 15:15:10]

Change committed as 139295