Adds NON_EXPORTED_BASE to AddressList base class.

Adds NON_EXPORTED_BASE to AddressList base class.

R=eroman@chromium.org
TEST=compiles with component build
NOTRY=true

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=135985

[eroman, 2012-05-08 21:39:55]

LGTM
@rvargas: Could you give this a sanity check as well?

[rvargas (doing something else), 2012-05-08 21:43:49]

I would not suppress the warning in this case :(

[eroman, 2012-05-08 21:51:27]

I recommend committing for now in order to fix problem.

As a follow up though, Ricardo has a good point that this could be risky
business. Is there any details that can leak through private inheritence?

One possible solution is my earlier comment #7:
http://codereview.chromium.org/10309002/#msg7

Although the downside is uglifying the consumer code.

[szym, 2012-05-08 21:59:30]

On 2012/05/08 21:51:27, eroman wrote:
> As a follow up though, Ricardo has a good point that this could be risky
> business. Is there any details that can leak through private inheritence?
> 
> One possible solution is my earlier comment #7:
> http://codereview.chromium.org/10309002/#msg7

Another option is to change it to typedef (since the canonical_name_ is going
away really soon now). The downsides are: it cannot be forward declared, we
loose AddressList:: namespace, and we lose type safety. The upside is that it's
less weird than having to use mutable_list, which will probably look like:

addresses->mutable_list()->push_back(address)

We also lose front, size, empty, clear and operator=.

[szym, 2012-05-08 22:00:14]

> We also lose front, size, empty, clear and operator=.

I meant we'd lose them if we used composition.

[rvargas (doing something else), 2012-05-08 22:03:03]

Committing as a quick fix for the build sounds reasonable to me.

[commit-bot: I haz the power, 2012-05-08 22:07:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/szym@chromium.org/10391019/1

[eroman, 2012-05-08 22:16:35]

Tpefdef sgtm once came is gone!
On May 8, 2012 3:07 PM, <commit-bot@chromium.org> wrote:

> CQ is trying da patch. Follow status at
>
https://chromium-status.**appspot.com/cq/szym@chromium.**org/10391019/1<https...
>
>
>
https://chromiumcodereview.**appspot.com/10391019/<https://chromiumcodereview...
>

[eroman, 2012-05-08 22:17:02]

Er "cname" (android freaking auto corrected that)
On May 8, 2012 3:15 PM, eroman@chromium.org wrote:

> Tpefdef sgtm once came is gone!
> On May 8, 2012 3:07 PM, <commit-bot@chromium.org> wrote:
>
>> CQ is trying da patch. Follow status at
>>
https://chromium-status.**appspot.com/cq/szym@chromium.**org/10391019/1<https...
>>
>>
>>
https://chromiumcodereview.**appspot.com/10391019/<https://chromiumcodereview...
>>
>

[commit-bot: I haz the power, 2012-05-09 04:00:34]

Try job failure for 10391019-1 (retry) (retry) (retry) on win_rel for step
"update".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-05-09 04:50:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/szym@chromium.org/10391019/1

[commit-bot: I haz the power, 2012-05-09 05:00:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/szym@chromium.org/10391019/1

[commit-bot: I haz the power, 2012-05-09 05:00:46]

Change committed as 135985