chrome/browser/resources/shared/js/cr/ui/menu_button.js - Issue 10389016: Use hidden attribute rather the 'display: none' for hiding menus.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/shared/js/cr/ui/menu_button.js

Issue 10389016: Use hidden attribute rather the 'display: none' for hiding menus. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Prevent FoUC with menus, using Evan's suggestion. Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/shared/js/cr/ui/menu_button.js

diff --git a/chrome/browser/resources/shared/js/cr/ui/menu_button.js b/chrome/browser/resources/shared/js/cr/ui/menu_button.js

index 5128c5dae56f0de7b669aee0d0f1fb2bfc69feea..09d17e5c44f3abfa927a873795b54ec5d647b1b0 100644

--- a/chrome/browser/resources/shared/js/cr/ui/menu_button.js

+++ b/chrome/browser/resources/shared/js/cr/ui/menu_button.js

@@ -113,7 +113,7 @@ cr.define('cr.ui', function() {

showMenu: function() {

this.hideMenu();

- this.menu.style.display = 'block';

+ this.menu.hidden = false;

this.setAttribute('menu-shown', '');

// when the menu is shown we steal all keyboard events.

@@ -136,7 +136,7 @@ cr.define('cr.ui', function() {

return;

this.removeAttribute('menu-shown');

- this.menu.style.display = 'none';

+ this.menu.hidden = true;

this.showingEvents_.removeAll();

this.menu.selectedIndex = -1;

« no previous file with comments | « chrome/browser/resources/shared/js/cr/ui/menu.js ('k') | no next file » | no next file with comments »