chrome/browser/resources/shared/js/cr/ui/menu.js - Issue 10389016: Use hidden attribute rather the 'display: none' for hiding menus.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/shared/js/cr/ui/menu.js

Issue 10389016: Use hidden attribute rather the 'display: none' for hiding menus. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Prevent FoUC with menus, using Evan's suggestion. Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/shared/js/cr/ui/menu.js

diff --git a/chrome/browser/resources/shared/js/cr/ui/menu.js b/chrome/browser/resources/shared/js/cr/ui/menu.js

index 1928293c60406441e95f1c5a3f450ed4d1b438cd..97c663bd4e33f4302fcb7cce372614a3a5995e74 100644

--- a/chrome/browser/resources/shared/js/cr/ui/menu.js

+++ b/chrome/browser/resources/shared/js/cr/ui/menu.js

@@ -26,6 +26,9 @@ cr.define('cr.ui', function() {

this.addEventListener('mouseover', this.handleMouseOver_);

this.addEventListener('mouseout', this.handleMouseOut_);

+ this.classList.add('decorated');

+ this.hidden = true; // Hide the menu by default.

// Decorate the children as menu items.

var children = this.children;

for (var i = 0, child; child = children[i]; i++) {