chrome/browser/extensions/api/webstore_private/webstore_private_api.h - Issue 10388252: Refactoring ExtenionInstallUI to abstract the Browser references.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/webstore_private/webstore_private_api.h

Issue 10388252: Refactoring ExtenionInstallUI to abstract the Browser references. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Synced + mac fix Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/permissions/permissions_api.cc ('k') | chrome/browser/extensions/api/webstore_private/webstore_private_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/webstore_private/webstore_private_api.h

diff --git a/chrome/browser/extensions/api/webstore_private/webstore_private_api.h b/chrome/browser/extensions/api/webstore_private/webstore_private_api.h

index cb890ad764fc4d359f7c7d24c9dac8f5c535fbd5..f65b5d12bf5c7fad9eabf3bbaaa0198065b71471 100644

--- a/chrome/browser/extensions/api/webstore_private/webstore_private_api.h

+++ b/chrome/browser/extensions/api/webstore_private/webstore_private_api.h

@@ -10,7 +10,7 @@

#include "chrome/browser/extensions/bundle_installer.h"

#include "chrome/browser/extensions/extension_function.h"

-#include "chrome/browser/extensions/extension_install_ui.h"

+#include "chrome/browser/extensions/extension_install_prompt.h"

#include "chrome/browser/extensions/webstore_install_helper.h"

#include "chrome/browser/extensions/webstore_installer.h"

#include "chrome/common/net/gaia/google_service_auth_error.h"

@@ -75,7 +75,7 @@ class InstallBundleFunction : public AsyncExtensionFunction,

class BeginInstallWithManifestFunction

: public AsyncExtensionFunction,

- public ExtensionInstallUI::Delegate,

+ public ExtensionInstallPrompt::Delegate,

public WebstoreInstallHelper::Delegate {

public:

DECLARE_EXTENSION_FUNCTION_NAME("webstorePrivate.beginInstallWithManifest3");

@@ -120,7 +120,7 @@ class BeginInstallWithManifestFunction

InstallHelperResultCode result_code,

const std::string& error_message) OVERRIDE;

- // ExtensionInstallUI::Delegate:

+ // ExtensionInstallPrompt::Delegate:

virtual void InstallUIProceed() OVERRIDE;

virtual void InstallUIAbort(bool user_initiated) OVERRIDE;

@@ -146,11 +146,11 @@ class BeginInstallWithManifestFunction

SkBitmap icon_;

// A dummy Extension object we create for the purposes of using

- // ExtensionInstallUI to prompt for confirmation of the install.

+ // ExtensionInstallPrompt to prompt for confirmation of the install.

scoped_refptr<extensions::Extension> dummy_extension_;

// The class that displays the install prompt.

- scoped_ptr<ExtensionInstallUI> install_ui_;

+ scoped_ptr<ExtensionInstallPrompt> install_prompt_;

};

class CompleteInstallFunction : public SyncExtensionFunction {