chrome/browser/extensions/api/webstore_private/webstore_private_api.cc - Issue 10388252: Refactoring ExtenionInstallUI to abstract the Browser references.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/webstore_private/webstore_private_api.cc

Issue 10388252: Refactoring ExtenionInstallUI to abstract the Browser references. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Synced + mac fix Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/webstore_private/webstore_private_api.h ('k') | chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/webstore_private/webstore_private_api.cc

diff --git a/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc b/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc

index df32a2fe29203d4e40e513b826f7782ee02ff983..00f7e85665bddcf68fffdae1681eb191392b7228 100644

--- a/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc

+++ b/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc

@@ -358,7 +358,7 @@ void BeginInstallWithManifestFunction::OnWebstoreParseSuccess(

parsed_manifest_.reset(parsed_manifest);

std::string error;

- dummy_extension_ = ExtensionInstallUI::GetLocalizedExtensionForDisplay(

+ dummy_extension_ = ExtensionInstallPrompt::GetLocalizedExtensionForDisplay(

parsed_manifest_.get(), id, localized_name_, "", &error);

if (!dummy_extension_) {

@@ -367,8 +367,8 @@ void BeginInstallWithManifestFunction::OnWebstoreParseSuccess(

return;

}

- install_ui_.reset(new ExtensionInstallUI(profile()));

- install_ui_->ConfirmWebstoreInstall(this, dummy_extension_, &icon_);

+ install_prompt_.reset(new ExtensionInstallPrompt(profile()));

+ install_prompt_->ConfirmWebstoreInstall(this, dummy_extension_, &icon_);

// Control flow finishes up in InstallUIProceed or InstallUIAbort.

}