Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: chrome/browser/extensions/extension_browsertest.cc

Issue 10388252: Refactoring ExtenionInstallUI to abstract the Browser references. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Minor clean-ups Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_browsertest.cc
diff --git a/chrome/browser/extensions/extension_browsertest.cc b/chrome/browser/extensions/extension_browsertest.cc
index 5297e1d9b12c390c0dc0ac1d0ba74f7a013959be..ad5bb392004a2dd489973cfeee46045305a7c298 100644
--- a/chrome/browser/extensions/extension_browsertest.cc
+++ b/chrome/browser/extensions/extension_browsertest.cc
@@ -17,7 +17,7 @@
#include "chrome/browser/extensions/crx_installer.h"
#include "chrome/browser/extensions/extension_creator.h"
#include "chrome/browser/extensions/extension_error_reporter.h"
-#include "chrome/browser/extensions/extension_install_ui.h"
+#include "chrome/browser/extensions/extension_install_prompt.h"
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/extensions/unpacked_installer.h"
#include "chrome/browser/profiles/profile.h"
@@ -225,9 +225,9 @@ FilePath ExtensionBrowserTest::PackExtensionWithOptions(
}
// This class is used to simulate an installation abort by the user.
-class MockAbortExtensionInstallUI : public ExtensionInstallUI {
+class MockAbortExtensionInstallPrompt : public ExtensionInstallPrompt {
public:
- MockAbortExtensionInstallUI() : ExtensionInstallUI(NULL) {}
+ MockAbortExtensionInstallPrompt() : ExtensionInstallPrompt(NULL) {}
// Simulate a user abort on an extension installation.
virtual void ConfirmInstall(Delegate* delegate, const Extension* extension) {
@@ -240,10 +240,10 @@ class MockAbortExtensionInstallUI : public ExtensionInstallUI {
virtual void OnInstallFailure(const string16& error) {}
};
-class MockAutoConfirmExtensionInstallUI : public ExtensionInstallUI {
+class MockAutoConfirmExtensionInstallPrompt : public ExtensionInstallPrompt {
public:
- explicit MockAutoConfirmExtensionInstallUI(Profile* profile) :
- ExtensionInstallUI(profile) {}
+ explicit MockAutoConfirmExtensionInstallPrompt(Profile* profile) :
+ ExtensionInstallPrompt(profile) {}
// Proceed without confirmation prompt.
virtual void ConfirmInstall(Delegate* delegate, const Extension* extension) {
@@ -280,13 +280,13 @@ const Extension* ExtensionBrowserTest::InstallOrUpdateExtension(
size_t num_before = service->extensions()->size();
{
- ExtensionInstallUI* install_ui = NULL;
+ ExtensionInstallPrompt* install_ui = NULL;
if (ui_type == INSTALL_UI_TYPE_CANCEL)
- install_ui = new MockAbortExtensionInstallUI();
+ install_ui = new MockAbortExtensionInstallPrompt();
else if (ui_type == INSTALL_UI_TYPE_NORMAL)
- install_ui = new ExtensionInstallUI(profile);
+ install_ui = new ExtensionInstallPrompt(profile);
else if (ui_type == INSTALL_UI_TYPE_AUTO_CONFIRM)
- install_ui = new MockAutoConfirmExtensionInstallUI(profile);
+ install_ui = new MockAutoConfirmExtensionInstallPrompt(profile);
// TODO(tessamac): Update callers to always pass an unpacked extension
// and then always pack the extension here.

Powered by Google App Engine
This is Rietveld 408576698