Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(797)

Unified Diff: chrome/browser/extensions/crx_installer_browsertest.cc

Issue 10388252: Refactoring ExtenionInstallUI to abstract the Browser references. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Minor clean-ups Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/crx_installer_browsertest.cc
diff --git a/chrome/browser/extensions/crx_installer_browsertest.cc b/chrome/browser/extensions/crx_installer_browsertest.cc
index 8a0c4bd1e3228d8bc7144e6de637058d3f644115..8a6cb72fed675e615b2d53c83aaa7c031c206b1d 100644
--- a/chrome/browser/extensions/crx_installer_browsertest.cc
+++ b/chrome/browser/extensions/crx_installer_browsertest.cc
@@ -8,7 +8,7 @@
#include "chrome/browser/download/download_test_observer.h"
#include "chrome/browser/extensions/crx_installer.h"
#include "chrome/browser/extensions/extension_browsertest.h"
-#include "chrome/browser/extensions/extension_install_ui.h"
+#include "chrome/browser/extensions/extension_install_prompt.h"
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser.h"
@@ -23,10 +23,10 @@ namespace {
// Observer waits for exactly one download to finish.
-class MockInstallUI : public ExtensionInstallUI {
+class MockInstallPrompt : public ExtensionInstallPrompt {
public:
- explicit MockInstallUI(Profile* profile) :
- ExtensionInstallUI(profile), confirmation_requested_(false) {}
+ explicit MockInstallPrompt(Profile* profile) :
+ ExtensionInstallPrompt(profile), confirmation_requested_(false) {}
// Did the Delegate request confirmation?
bool confirmation_requested() { return confirmation_requested_; }
@@ -60,7 +60,8 @@ class ExtensionCrxInstallerTest : public ExtensionBrowserTest {
bool DidWhitelistInstallPrompt(const std::string& ext_relpath,
const std::string& id) {
ExtensionService* service = browser()->profile()->GetExtensionService();
- MockInstallUI* mock_install_ui = new MockInstallUI(browser()->profile());
+ MockInstallPrompt* mock_install_ui =
+ new MockInstallPrompt(browser()->profile());
FilePath ext_path = test_data_dir_.AppendASCII(ext_relpath);
std::string error;
@@ -140,8 +141,8 @@ IN_PROC_BROWSER_TEST_F(ExtensionCrxInstallerTest, PackAndInstallExtension) {
std::string crx_path_string(crx_path.value().begin(), crx_path.value().end());
GURL url = GURL(std::string("file:///").append(crx_path_string));
- MockInstallUI* mock_ui = new MockInstallUI(browser()->profile());
- download_crx_util::SetMockInstallUIForTesting(mock_ui);
+ MockInstallPrompt* mock_prompt = new MockInstallPrompt(browser()->profile());
+ download_crx_util::SetMockInstallPromptForTesting(mock_prompt);
LOG(ERROR) << "PackAndInstallExtension: Getting download manager";
content::DownloadManager* download_manager =
@@ -159,6 +160,6 @@ IN_PROC_BROWSER_TEST_F(ExtensionCrxInstallerTest, PackAndInstallExtension) {
EXPECT_TRUE(WaitForExtensionInstall());
LOG(ERROR) << "PackAndInstallExtension: Extension install";
- EXPECT_TRUE(mock_ui->confirmation_requested());
+ EXPECT_TRUE(mock_prompt->confirmation_requested());
LOG(ERROR) << "PackAndInstallExtension: Extension install confirmed";
}

Powered by Google App Engine
This is Rietveld 408576698