Issue 10388161: Initial work on computing SSA.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10388161: Initial work on computing SSA. (Closed)

Created:
8 years, 7 months ago by Kevin Millikin (Google)

Modified:
8 years, 3 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Initial work on computing SSA. Insert (dummy) phis in all the right place. Still to go: renaming. BUG= TEST= Landed in a different CL.

Patch Set 1 #

Total comments: 1

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+86 lines, -0 lines)			Patch
M	runtime/vm/flow_graph_builder.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	1 chunk	+79 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1 chunk	+2 lines, -0 lines	1 comment	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Google)

8 years, 7 months ago (2012-05-16 15:33:08 UTC) #1

http://codereview.chromium.org/10388161/diff/1/runtime/vm/intermediate_langua...
File runtime/vm/intermediate_language.h (right):

http://codereview.chromium.org/10388161/diff/1/runtime/vm/intermediate_langua...
runtime/vm/intermediate_language.h:1366: void InsertPhi(intptr_t variable_index)
{ }
This needs an implementation that adds a Phi with PredecessorCount()
uninitialized inputs.

Expand Messages | Collapse Messages