Full-screen Magnifier: Support warping the cursor on the edge

ui/aura/root_window.cc

Index: ui/aura/root_window.cc
diff --git a/ui/aura/root_window.cc b/ui/aura/root_window.cc
index a78db6983ec2cbbed2f5f74cce4c1f4c988387bc..ddf3346a5eb756122f5b2f4c3fd5b7010ee6317e 100644
--- a/ui/aura/root_window.cc
+++ b/ui/aura/root_window.cc
@@ -32,6 +32,7 @@
 #include "ui/compositor/layer_animator.h"
 #include "ui/gfx/monitor.h"
 #include "ui/gfx/screen.h"
+#include "ui/gfx/point3.h"

[sky, 2012/06/07 18:05:50]

sort

[yoshiki, 2012/06/08 22:27:45]

Done.

 
 using std::vector;
 
@@ -218,7 +219,11 @@ void RootWindow::ShowCursor(bool show) {
 }
 
 void RootWindow::MoveCursorTo(const gfx::Point& location_in_dip) {
-  host_->MoveCursorTo(ui::ConvertPointToPixel(layer(), location_in_dip));
+  gfx::Point3f p3(location_in_dip);

[sky, 2012/06/07 18:05:50]

Why do we need point3 here?

[oshima, 2012/06/07 18:25:07]

Transform convert gfx::point to point3 internally, so you don't need this here.

[yoshiki, 2012/06/08 22:27:45]

Done.

+  layer()->transform().TransformPoint(p3);

[oshima, 2012/06/07 18:25:07]

I believe location_in_dip is in DIP coordinate system that is already
transformed using this transform() + scale factor.
Please see render_widget_host_viwe_aura.cc

[yoshiki, 2012/06/08 22:27:45]

oshima: Sorry, I can't find it in render_widget_host_view_aura.cc. There seems
to be no transforming operation. Could you teach me where is it? 

Anyway, I think this transform should be here, not on
render_widget_host_viwe_aura.cc. Because this transforming of location, which
will be sent to the host with host->MoveCursorTo(), is the reverse calculation
of the transforms used for event locations from the host
(event->UpdateForRootTransform()) in root_window,cc. I think the location both
from the host and to the host should be transformed on same layer. What would
you advise about it?

[oshima, 2012/06/11 16:51:18]

no, what I meant is the all mouse events fed to aura and up are already
transformed in RootWindow::DispatchMouseEventImpl, including the event in
render_widget_host_view_aura, so applying here means you're applying the same
transform to the event location twice.

+  gfx::Point p(p3.AsPoint());
+
+  host_->MoveCursorTo(ui::ConvertPointToPixel(layer(), p));
 }
 
 bool RootWindow::ConfineCursorToWindow() {