Full-screen Magnifier: Support warping the cursor on the edge

ui/aura/root_window.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/aura/root_window.h"
 
 #include <vector>
 
 #include "base/bind.h"
 #include "base/command_line.h"
@@ skipping 14 matching lines @@
 #include "ui/aura/window_delegate.h"
 #include "ui/base/gestures/gesture_recognizer.h"
 #include "ui/base/gestures/gesture_types.h"
 #include "ui/base/hit_test.h"
 #include "ui/compositor/compositor.h"
 #include "ui/compositor/dip_util.h"
 #include "ui/compositor/layer.h"
 #include "ui/compositor/layer_animator.h"
 #include "ui/gfx/monitor.h"
 #include "ui/gfx/screen.h"
+#include "ui/gfx/point3.h"

[sky, 2012/06/07 18:05:50]

sort

[yoshiki, 2012/06/08 22:27:45]

Done.

 
 using std::vector;
 
 namespace aura {
 
 namespace {
 
 // These are the mouse events generated when a gesture goes unprocessed.
 const ui::EventType kScrollBeginTypes[] = {
   ui::ET_MOUSE_PRESSED, ui::ET_MOUSE_DRAGGED, ui::ET_UNKNOWN };
@@ skipping 166 matching lines @@
   // so just pass everything along to the host.
   host_->SetCursor(cursor);
 }
 
 void RootWindow::ShowCursor(bool show) {
   cursor_shown_ = show;
   host_->ShowCursor(show);
 }
 
 void RootWindow::MoveCursorTo(const gfx::Point& location_in_dip) {
-  host_->MoveCursorTo(ui::ConvertPointToPixel(layer(), location_in_dip));
+  gfx::Point3f p3(location_in_dip);

[sky, 2012/06/07 18:05:50]

Why do we need point3 here?

[oshima, 2012/06/07 18:25:07]

Transform convert gfx::point to point3 internally, so you don't need this here.

[yoshiki, 2012/06/08 22:27:45]

Done.

+  layer()->transform().TransformPoint(p3);

[oshima, 2012/06/07 18:25:07]

I believe location_in_dip is in DIP coordinate system that is already
transformed using this transform() + scale factor.
Please see render_widget_host_viwe_aura.cc

[yoshiki, 2012/06/08 22:27:45]

oshima: Sorry, I can't find it in render_widget_host_view_aura.cc. There seems
to be no transforming operation. Could you teach me where is it? 

Anyway, I think this transform should be here, not on
render_widget_host_viwe_aura.cc. Because this transforming of location, which
will be sent to the host with host->MoveCursorTo(), is the reverse calculation
of the transforms used for event locations from the host
(event->UpdateForRootTransform()) in root_window,cc. I think the location both
from the host and to the host should be transformed on same layer. What would
you advise about it?

[oshima, 2012/06/11 16:51:18]

no, what I meant is the all mouse events fed to aura and up are already
transformed in RootWindow::DispatchMouseEventImpl, including the event in
render_widget_host_view_aura, so applying here means you're applying the same
transform to the event location twice.

+  gfx::Point p(p3.AsPoint());
+
+  host_->MoveCursorTo(ui::ConvertPointToPixel(layer(), p));
 }
 
 bool RootWindow::ConfineCursorToWindow() {
   // We would like to be able to confine the cursor to that window. However,
   // currently, we do not have such functionality in X. So we just confine
   // to the root window. This is ok because this option is currently only
   // being used in fullscreen mode, so root_window bounds = window bounds.
   return host_->ConfineCursorToRootWindow();
 }
 
@@ skipping 787 matching lines @@
 void RootWindow::UnlockCompositor() {
   DCHECK(compositor_lock_);
   compositor_lock_ = NULL;
   if (draw_on_compositor_unlock_) {
     draw_on_compositor_unlock_ = false;
     ScheduleDraw();
   }
 }
 
 }  // namespace aura