Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2180)

Unified Diff: content/shell/android/content_shell_apk.xml

Issue 10388067: Fix the content_shell.apk in android x86 target build bug (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« content/content_shell.gypi ('K') | « content/content_shell.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/android/content_shell_apk.xml
diff --git a/content/shell/android/content_shell_apk.xml b/content/shell/android/content_shell_apk.xml
index 003380bd046721c9231b1c54a6691b315e855f40..9ad848f368863be3fca38662d8d264aaea459769 100644
--- a/content/shell/android/content_shell_apk.xml
+++ b/content/shell/android/content_shell_apk.xml
@@ -13,6 +13,8 @@
<property environment="env"/>
<property name="sdk.dir" location="${env.ANDROID_SDK_ROOT}"/>
<property name="toolchain.dir" location="${env.ANDROID_TOOLCHAIN}"/>
+ <property name="toolchain.dir" location="${env.ANDROID_TOOLCHAIN}"/>
+ <property name="target.arch" value="${env.TARGET_PRODUCT}"/>
<property name="source.dir" location="java"/>
<property name="target" value="android-14"/>
<property name="out.dir" location="${PRODUCT_DIR}/content_shell"/>
@@ -58,9 +60,21 @@
</condition>
<then>
<echo message="Copying gdbserver to the apk to enable native debugging"/>
- <copy todir="${out.dir}/libs/armeabi">
- <path refid="native.libs.gdbserver"/>
- </copy>
+ <if>
John Grabowski 2012/05/10 15:06:18 Can we generalize this a bit more? E.g. make cond
Shouqun Liu 2012/05/11 02:45:23 Yes, strongly agree, use the APP_ABI argument pass
+ <condition>
+ <equals arg1="${target.arch}" arg2="x86"/>
+ </condition>
+ <then>
+ <copy todir="${out.dir}/libs/x86">
+ <path refid="native.libs.gdbserver"/>
+ </copy>
+ </then>
+ <else>
+ <copy todir="${out.dir}/libs/armeabi">
+ <path refid="native.libs.gdbserver"/>
+ </copy>
+ </else>
+ </if>
</then>
</if>
</target>
« content/content_shell.gypi ('K') | « content/content_shell.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698