Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Side by Side Diff: content/shell/android/content_shell_apk.xml

Issue 10388067: Fix the content_shell.apk in android x86 target build bug (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« content/content_shell.gypi ('K') | « content/content_shell.gypi ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <?xml version="1.0" encoding="UTF-8"?> 1 <?xml version="1.0" encoding="UTF-8"?>
2 <!-- 2 <!--
3 Copyright (c) 2012 The Chromium Authors. All rights reserved. 3 Copyright (c) 2012 The Chromium Authors. All rights reserved.
4 Use of this source code is governed by a BSD-style license that can be 4 Use of this source code is governed by a BSD-style license that can be
5 found in the LICENSE file. 5 found in the LICENSE file.
6 --> 6 -->
7 <project name="ContentShell" default="debug" basedir="."> 7 <project name="ContentShell" default="debug" basedir=".">
8 8
9 <description> 9 <description>
10 Building ContentShell.apk 10 Building ContentShell.apk
11 </description> 11 </description>
12 12
13 <property environment="env"/> 13 <property environment="env"/>
14 <property name="sdk.dir" location="${env.ANDROID_SDK_ROOT}"/> 14 <property name="sdk.dir" location="${env.ANDROID_SDK_ROOT}"/>
15 <property name="toolchain.dir" location="${env.ANDROID_TOOLCHAIN}"/> 15 <property name="toolchain.dir" location="${env.ANDROID_TOOLCHAIN}"/>
16 <property name="toolchain.dir" location="${env.ANDROID_TOOLCHAIN}"/>
17 <property name="target.arch" value="${env.TARGET_PRODUCT}"/>
16 <property name="source.dir" location="java"/> 18 <property name="source.dir" location="java"/>
17 <property name="target" value="android-14"/> 19 <property name="target" value="android-14"/>
18 <property name="out.dir" location="${PRODUCT_DIR}/content_shell"/> 20 <property name="out.dir" location="${PRODUCT_DIR}/content_shell"/>
19 <property name="resource.absolute.dir" value="res"/> 21 <property name="resource.absolute.dir" value="res"/>
20 <property name="gen.absolute.dir" value="${out.dir}/gen"/> 22 <property name="gen.absolute.dir" value="${out.dir}/gen"/>
21 <property name="jar.libs.dir" value="${out.dir}/java/libs"/> 23 <property name="jar.libs.dir" value="${out.dir}/java/libs"/>
22 <path id="native.libs.gdbserver"> 24 <path id="native.libs.gdbserver">
23 <fileset file="${toolchain.dir}/../../gdbserver"/> 25 <fileset file="${toolchain.dir}/../../gdbserver"/>
24 </path> 26 </path>
25 <property name="native.libs.absolute.dir" location="${out.dir}/libs" /> 27 <property name="native.libs.absolute.dir" location="${out.dir}/libs" />
(...skipping 25 matching lines...) Expand all
51 TODO(jrg): for now, Chrome on Android always builds native code 53 TODO(jrg): for now, Chrome on Android always builds native code
52 as Release and java/ant as Debug, which means we always install 54 as Release and java/ant as Debug, which means we always install
53 gdbserver. Resolve this discrepancy, possibly by making this 55 gdbserver. Resolve this discrepancy, possibly by making this
54 Release Official build java/ant as Release. --> 56 Release Official build java/ant as Release. -->
55 <if> 57 <if>
56 <condition> 58 <condition>
57 <equals arg1="${build.target}" arg2="debug" /> 59 <equals arg1="${build.target}" arg2="debug" />
58 </condition> 60 </condition>
59 <then> 61 <then>
60 <echo message="Copying gdbserver to the apk to enable native debugging"/ > 62 <echo message="Copying gdbserver to the apk to enable native debugging"/ >
61 <copy todir="${out.dir}/libs/armeabi"> 63 <if>
John Grabowski 2012/05/10 15:06:18 Can we generalize this a bit more? E.g. make cond
Shouqun Liu 2012/05/11 02:45:23 Yes, strongly agree, use the APP_ABI argument pass
62 <path refid="native.libs.gdbserver"/> 64 <condition>
63 </copy> 65 <equals arg1="${target.arch}" arg2="x86"/>
66 </condition>
67 <then>
68 <copy todir="${out.dir}/libs/x86">
69 <path refid="native.libs.gdbserver"/>
70 </copy>
71 </then>
72 <else>
73 <copy todir="${out.dir}/libs/armeabi">
74 <path refid="native.libs.gdbserver"/>
75 </copy>
76 </else>
77 </if>
64 </then> 78 </then>
65 </if> 79 </if>
66 </target> 80 </target>
67 81
68 <import file="${sdk.dir}/tools/ant/build.xml" /> 82 <import file="${sdk.dir}/tools/ant/build.xml" />
69 83
70 </project> 84 </project>
OLDNEW
« content/content_shell.gypi ('K') | « content/content_shell.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698