Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: content/content_shell.gypi

Issue 10388067: Fix the content_shell.apk in android x86 target build bug (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/content_shell.gypi
diff --git a/content/content_shell.gypi b/content/content_shell.gypi
index 4a67c23a1e8b802d195e4f715033a1d240bd4112..f18e1edad723dcda11ea0718c141592da1ffd9da 100644
--- a/content/content_shell.gypi
+++ b/content/content_shell.gypi
@@ -520,6 +520,16 @@
{
'target_name': 'content_shell_apk',
'type': 'none',
+ 'variables': {
+ 'conditions': [
+ [ 'target_arch == "arm"', {
John Grabowski 2012/05/10 15:06:18 file convention would be more 'target_arch=="ARM"'
Shouqun Liu 2012/05/11 02:45:23 Done.
+ 'content_shell_content_view_so%': '<(PRODUCT_DIR)/content_shell/libs/armeabi/libcontent_shell_content_view.so',
John Grabowski 2012/05/10 15:06:18 Might be a bit nicer to have a new variable which
Shouqun Liu 2012/05/11 02:45:23 yes, agree, use a variable 'android_app_abi' in co
+ }],
+ [ 'target_arch == "ia32"', {
+ 'content_shell_content_view_so%': '<(PRODUCT_DIR)/content_shell/libs/x86/libcontent_shell_content_view.so',
+ }],
+ ],
+ },
'actions': [
{
'action_name': 'copy_base_jar',
@@ -548,7 +558,7 @@
{
'action_name': 'copy_and_strip_so',
'inputs': ['<(SHARED_LIB_DIR)/libcontent_shell_content_view.so'],
- 'outputs': ['<(PRODUCT_DIR)/content_shell/libs/armeabi/libcontent_shell_content_view.so'],
+ 'outputs': ['<(content_shell_content_view_so)'],
'action': [
'<!(/bin/echo -n $STRIP)',
'--strip-unneeded', # All symbols not needed for relocation.
@@ -568,7 +578,7 @@
'<(PRODUCT_DIR)/content_shell/java/libs/chromium_net.jar',
'<(PRODUCT_DIR)/content_shell/java/libs/chromium_media.jar',
'<(PRODUCT_DIR)/content_shell/java/libs/chromium_content.jar',
- '<(PRODUCT_DIR)/content_shell/libs/armeabi/libcontent_shell_content_view.so',
+ '<(content_shell_content_view_so)',
],
'outputs': [
# Awkwardly, we build a Debug APK even when gyp is in
« no previous file with comments | « no previous file | content/shell/android/content_shell_apk.xml » ('j') | content/shell/android/content_shell_apk.xml » ('J')

Powered by Google App Engine
This is Rietveld 408576698