Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(969)

Side by Side Diff: tools/test.dart

Issue 10387232: Remove string concatenation with + from all Dart files in tools directory. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 #!/usr/bin/env dart 1 #!/usr/bin/env dart
2 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 2 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
3 // for details. All rights reserved. Use of this source code is governed by a 3 // for details. All rights reserved. Use of this source code is governed by a
4 // BSD-style license that can be found in the LICENSE file. 4 // BSD-style license that can be found in the LICENSE file.
5 5
6 /** 6 /**
7 * This file is the entrypoint of the dart test suite. This suite is used 7 * This file is the entrypoint of the dart test suite. This suite is used
8 * to test: 8 * to test:
9 * 9 *
10 * 1. the dart vm 10 * 1. the dart vm
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
76 var maxProcesses = firstConf['tasks']; 76 var maxProcesses = firstConf['tasks'];
77 var progressIndicator = firstConf['progress']; 77 var progressIndicator = firstConf['progress'];
78 var verbose = firstConf['verbose']; 78 var verbose = firstConf['verbose'];
79 var printTiming = firstConf['time']; 79 var printTiming = firstConf['time'];
80 var listTests = firstConf['list']; 80 var listTests = firstConf['list'];
81 81
82 // Print the configurations being run by this execution of 82 // Print the configurations being run by this execution of
83 // test.dart. However, don't do it if the silent progress indicator 83 // test.dart. However, don't do it if the silent progress indicator
84 // is used. This is only needed because of the junit tests. 84 // is used. This is only needed because of the junit tests.
85 if (progressIndicator != 'silent') { 85 if (progressIndicator != 'silent') {
86 StringBuffer sb = new StringBuffer('Test configuration'); 86 List<String> output_words = configurations.length > 1 ?
Bob Nystrom 2012/05/22 17:23:14 Ditto.
87 sb.add(configurations.length > 1 ? 's:' : ':'); 87 ['Test configurations:'] : ['Test configuration:'];
88 for (Map conf in configurations) { 88 for (Map conf in configurations) {
89 sb.add(' ${conf["compiler"]}_${conf["runtime"]}_${conf["mode"]}_' + 89 List settings =
90 '${conf["arch"]}'); 90 ['compiler', 'runtime', 'mode', 'arch'].map((name) => conf[name]);
91 if (conf['checked']) sb.add('_checked'); 91 if (conf['checked']) settings.add('checked');
92 output_words.add(Strings.join(settings, '_'));
92 } 93 }
93 print(sb); 94 print(Strings.join(output_words, ' '));
94 } 95 }
95 96
96 var configurationIterator = configurations.iterator(); 97 var configurationIterator = configurations.iterator();
97 bool enqueueConfiguration(ProcessQueue queue) { 98 bool enqueueConfiguration(ProcessQueue queue) {
98 if (!configurationIterator.hasNext()) { 99 if (!configurationIterator.hasNext()) {
99 return false; 100 return false;
100 } 101 }
101 102
102 var conf = configurationIterator.next(); 103 var conf = configurationIterator.next();
103 for (String key in selectors.getKeys()) { 104 for (String key in selectors.getKeys()) {
(...skipping 22 matching lines...) Expand all
126 127
127 // Start process queue. 128 // Start process queue.
128 var queue = new ProcessQueue(maxProcesses, 129 var queue = new ProcessQueue(maxProcesses,
129 progressIndicator, 130 progressIndicator,
130 startTime, 131 startTime,
131 printTiming, 132 printTiming,
132 enqueueConfiguration, 133 enqueueConfiguration,
133 verbose, 134 verbose,
134 listTests); 135 listTests);
135 } 136 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698