Die build.py, Die: Part 1 (BranchUtility and SubversionFetcher)

chrome/common/extensions/docs/server2/fetch.py

Index: chrome/common/extensions/docs/server2/fetch.py
diff --git a/chrome/common/extensions/docs/server2/fetch.py b/chrome/common/extensions/docs/server2/fetch.py
new file mode 100644
index 0000000000000000000000000000000000000000..e6473bb2d16f7cac39b8e411f28154fcdde1f2f0
--- /dev/null
+++ b/chrome/common/extensions/docs/server2/fetch.py
@@ -0,0 +1,20 @@
+# Copyright (c) 2012 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+from google.appengine.api import urlfetch
+
+class FetchException(Exception):
+  """Thrown when status code is not 200.
+  """
+  def __init__(self, url):
+    Exception.__init__(self, 'Fetch exception from ' + url)
+
+def Fetch(url):
+  result = urlfetch.fetch(
+      url="http://omahaproxy.appspot.com/json",

[Aaron Boodman, 2012/05/22 22:45:02]

I don't think this or the stuff in google/appengine is necessary.

We should use dependency injection. Wherever we need to fetch urls, we take a
url_fetch as an argument to the caller's cosntructor. During test, we supply a
fake url fetcher, and in real life we use the one from app engine.

Later in our work, we can wrap the url_fetch module from app engine with a
version that consults memcache before the web.

[cduvall, 2012/05/24 00:15:40]

Much better, good idea.

+      method=urlfetch.GET)
+
+  if result.status_code != 200:
+    raise FetchException(url)
+  return result.content