Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Unified Diff: ipc/ipc_tests.h

Issue 10387218: Make GlobalDescriptors::MaybeGet return -1 when the key is not found. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Applied Jeremy's suggestions + sync. Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ipc/ipc_tests.h
diff --git a/ipc/ipc_tests.h b/ipc/ipc_tests.h
index f4fa113088ee84ae614f162aac1a0b8b150be4c3..3b4709986a9fb84f4ed15a2bc91038d2d659161c 100644
--- a/ipc/ipc_tests.h
+++ b/ipc/ipc_tests.h
@@ -9,6 +9,9 @@
#include "base/test/multiprocess_test.h"
#include "base/process.h"
+#define MULTIPROCESS_IPC_TEST_MAIN(test_main) \
jeremy 2012/06/13 20:46:28 Can you add a comment that explains when a test ne
Jay Civelli 2012/06/22 23:28:29 Done.
+ MULTIPROCESS_TEST_MAIN_WITH_SETUP(test_main, MultiProcessTestIPCSetUp)
+
// This unit test uses 3 types of child processes, a regular pipe client,
// a client reflector and a IPC server used for fuzzing tests.
enum ChildType {
@@ -46,4 +49,8 @@ class IPCChannelTest : public base::MultiProcessTest {
MessageLoopForIO* message_loop_;
};
+// Setup function used by MULTIPROCESS_IPC_TEST_MAIN.
+// Registers the IPC channel as a global descriptor on Posix.
jeremy 2012/06/13 20:46:28 Can you expand this comment, esp. it's not clear w
Jay Civelli 2012/06/22 23:28:29 Done.
+int MultiProcessTestIPCSetUp();
+
#endif // IPC_IPC_TESTS_H_
« no previous file with comments | « ipc/ipc_send_fds_test.cc ('k') | ipc/ipc_tests.cc » ('j') | testing/multiprocess_func_list.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698