Make GlobalDescriptors::MaybeGet return -1 when the key is not found.

ipc/ipc_tests.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef IPC_IPC_TESTS_H_
 #define IPC_IPC_TESTS_H_
 #pragma once
 
 #include "base/test/multiprocess_test.h"
 #include "base/process.h"
 
+#define MULTIPROCESS_IPC_TEST_MAIN(test_main) \

[jeremy, 2012/06/13 20:46:28]

Can you add a comment that explains when a test needs to use this.

[Jay Civelli, 2012/06/22 23:28:29]

Done.

+  MULTIPROCESS_TEST_MAIN_WITH_SETUP(test_main, MultiProcessTestIPCSetUp)
+
 // This unit test uses 3 types of child processes, a regular pipe client,
 // a client reflector and a IPC server used for fuzzing tests.
 enum ChildType {
   TEST_CLIENT,
   TEST_DESCRIPTOR_CLIENT,
   TEST_DESCRIPTOR_CLIENT_SANDBOXED,
   TEST_REFLECTOR,
   FUZZER_SERVER,
   SYNC_SOCKET_SERVER
 };
@@ skipping 17 matching lines @@
   virtual void SetUp() OVERRIDE;
   virtual void TearDown() OVERRIDE;
 
   // Spawns a child process of the specified type
   base::ProcessHandle SpawnChild(ChildType child_type, IPC::Channel* channel);
 
   // Created around each test instantiation.
   MessageLoopForIO* message_loop_;
 };
 
+// Setup function used by MULTIPROCESS_IPC_TEST_MAIN.
+// Registers the IPC channel as a global descriptor on Posix.

[jeremy, 2012/06/13 20:46:28]

Can you expand this comment, esp. it's not clear why this is needed.

[Jay Civelli, 2012/06/22 23:28:29]

Done.

+int MultiProcessTestIPCSetUp();
+
 #endif  // IPC_IPC_TESTS_H_