Record API fix adding FirstRun, and allowing repeat-count in capture (plus some browsertests along …

chrome/browser/extensions/extension_record_api.h

Index: chrome/browser/extensions/extension_record_api.h
diff --git a/chrome/browser/extensions/extension_record_api.h b/chrome/browser/extensions/extension_record_api.h
index e7ad077fe366c3b9a4e906b57f22d86f630b53be..f4a05f377b7a9780be987f5f1b6a46838396c7c1 100644
--- a/chrome/browser/extensions/extension_record_api.h
+++ b/chrome/browser/extensions/extension_record_api.h
@@ -90,6 +90,7 @@ class RunPageCyclerFunction : public AsyncExtensionFunction {
 
   FilePath user_data_dir_;
   std::string url_contents_;
+  int repeat_count_;

[Aaron Boodman, 2012/06/05 04:17:04]

Why does capture need the concept of 'repeat count'?

[clintstaley, 2012/06/05 20:46:08]

Because of the vagaries of the record mode and playback mode features of Chrome.
 One cannot do a playback of multiple repetitions unless the record on which it
was based also had the same multiple repetitions.  (Devlin indicates you and he
discussed this a while back.).  Thus, the capture must set up the repeat count,
and the playback follows suit.

   std::vector<std::string> errors_;
 
   // Base CommandLine on which to build the test browser CommandLine
@@ -143,7 +144,6 @@ class ReplayURLsFunction : public RunPageCyclerFunction {
 
   // These three data are additional information added to the sub-browser
   // commandline.
-  int repeat_count_;
   FilePath extension_path_;
   FilePath stats_file_path_;