Record API fix adding FirstRun, and allowing repeat-count in capture (plus some browsertests along …

chrome/browser/extensions/extension_record_api.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_RECORD_API_H_
 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_RECORD_API_H_
 #pragma once
 
 #include "chrome/browser/extensions/extension_function.h"
 #include "base/command_line.h"
@@ skipping 72 matching lines @@
   // possibly other data by posting them to text files.  ReadReplyFiles
   // collects these data for return to the JS side caller.
   virtual void ReadReplyFiles() {}
 
   // Return the values gathered in RunTestBrowser.  No common code here; all
   // logic is in subclasses.
   virtual void Finish() {}
 
   FilePath user_data_dir_;
   std::string url_contents_;
+  int repeat_count_;

[Aaron Boodman, 2012/06/05 04:17:04]

Why does capture need the concept of 'repeat count'?

[clintstaley, 2012/06/05 20:46:08]

Because of the vagaries of the record mode and playback mode features of Chrome.
 One cannot do a playback of multiple repetitions unless the record on which it
was based also had the same multiple repetitions.  (Devlin indicates you and he
discussed this a while back.).  Thus, the capture must set up the repeat count,
and the playback follows suit.

   std::vector<std::string> errors_;
 
   // Base CommandLine on which to build the test browser CommandLine
   CommandLine base_command_line_;
 
   // ProcessStrategy to use for this run.
   scoped_ptr<ProcessStrategy> process_strategy_;
 };
 
 class CaptureURLsFunction : public RunPageCyclerFunction {
@@ skipping 33 matching lines @@
   virtual void AddSwitches(CommandLine* command_line) OVERRIDE;
 
   // Read stats file.
   virtual void ReadReplyFiles() OVERRIDE;
 
   // Return error list, statistical results, and runtime.
   virtual void Finish() OVERRIDE;
 
   // These three data are additional information added to the sub-browser
   // commandline.
-  int repeat_count_;
   FilePath extension_path_;
   FilePath stats_file_path_;
 
   // This time datum marks the start and end of the sub-browser run.
   base::Time timer_;
 
   // These two data are additional information returned to caller.
   int run_time_ms_;
   std::string stats_;
 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_RECORD_API_H_