lib/dom/src/native_DOMWrapperBase.dart - Issue 10383302: Move dart:dom implementation classes to dart:html library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/dom/src/native_DOMWrapperBase.dart

Issue 10383302: Move dart:dom implementation classes to dart:html library. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« lib/dom/scripts/systemnative.py ('K') | « lib/dom/src/native_DOMImplementation.dart ('k') | lib/dom/templates/dom/native/cpp_implementation.template » ('j') | lib/dom/templates/dom/native/dart_implementation.darttemplate » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: lib/dom/src/native_DOMWrapperBase.dart

diff --git a/lib/dom/src/native_DOMWrapperBase.dart b/lib/dom/src/native_DOMWrapperBase.dart

index cd9ae886710ae7c3f37d8ce479f830c1e0dc4a60..d8073d1d72721c4fc230e2eccb21bd53c2aa92d4 100644

--- a/lib/dom/src/native_DOMWrapperBase.dart

+++ b/lib/dom/src/native_DOMWrapperBase.dart

@@ -2,6 +2,8 @@

// BSD-style license that can be found in the LICENSE file.

-class DOMWrapperBase extends NativeFieldWrapperClass1 implements DOMType {

+class _DOMWrapperBase extends NativeFieldWrapperClass1 {

var dartObjectLocalStorage;

+ String get typeName() => "";

Anton Muhin 2012/05/23 14:03:31 why this getter?

podivilov 2012/05/23 14:52:40 It is used in _wrap. Was previously declared on DO

Anton Muhin 2012/05/23 15:25:23 If it's overridden by subclasses, why we need to p

podivilov 2012/05/24 10:33:07 Done.

}