lib/dom/src/native_DOMWrapperBase.dart - Issue 10383302: Move dart:dom implementation classes to dart:html library.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: lib/dom/src/native_DOMWrapperBase.dart

Issue 10383302: Move dart:dom implementation classes to dart:html library. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« lib/dom/scripts/systemnative.py ('K') | « lib/dom/src/native_DOMImplementation.dart ('k') | lib/dom/templates/dom/native/cpp_implementation.template » ('j') | lib/dom/templates/dom/native/dart_implementation.darttemplate » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file	1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file

2 // for details. All rights reserved. Use of this source code is governed by a	2 // for details. All rights reserved. Use of this source code is governed by a

3 // BSD-style license that can be found in the LICENSE file.	3 // BSD-style license that can be found in the LICENSE file.

4	4

5 class DOMWrapperBase extends NativeFieldWrapperClass1 implements DOMType {	5 class _DOMWrapperBase extends NativeFieldWrapperClass1 {

6 var dartObjectLocalStorage;	6 var dartObjectLocalStorage;

	7

	8 String get typeName() => "";
	Anton Muhin 2012/05/23 14:03:31 why this getter? why this getter? podivilov 2012/05/23 14:52:40 It is used in _wrap. Was previously declared on DO Show quoted text On 2012/05/23 14:03:31, antonmuhin wrote: > why this getter? It is used in _wrap. Was previously declared on DOMType. Anton Muhin 2012/05/23 15:25:23 If it's overridden by subclasses, why we need to p If it's overridden by subclasses, why we need to provide such an implementation? Maybe declare abstract or throw an exception instead? On 2012/05/23 14:52:40, podivilov wrote: Show quoted text > On 2012/05/23 14:03:31, antonmuhin wrote: > > why this getter? > > It is used in _wrap. Was previously declared on DOMType. podivilov 2012/05/24 10:33:07 Done. Show quoted text On 2012/05/23 15:25:23, antonmuhin wrote: > If it's overridden by subclasses, why we need to provide such an implementation? > Maybe declare abstract or throw an exception instead? > > On 2012/05/23 14:52:40, podivilov wrote: > > On 2012/05/23 14:03:31, antonmuhin wrote: > > > why this getter? > > > > It is used in _wrap. Was previously declared on DOMType. > Done.
7 }	9 }

OLD	NEW