Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1345)

Unified Diff: content/common/gpu/gpu_command_buffer_stub.h

Issue 10383262: RefCounted types should not have public destructors, delegate cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/gpu/gpu_command_buffer_stub.h
diff --git a/content/common/gpu/gpu_command_buffer_stub.h b/content/common/gpu/gpu_command_buffer_stub.h
index 2c81c98ac6abed12d3ee487a700a633f719a07b5..3f149cb148f54a60130d332ed820d708869a2475 100644
--- a/content/common/gpu/gpu_command_buffer_stub.h
+++ b/content/common/gpu/gpu_command_buffer_stub.h
@@ -84,10 +84,11 @@ class GpuCommandBufferStub
public:
class DestructionObserver {
public:
- ~DestructionObserver() {}
-
// Called in Destroy(), before the context/surface are released.
virtual void OnWillDestroyStub(GpuCommandBufferStub* stub) = 0;
+
+ protected:
+ virtual ~DestructionObserver() {}
};
GpuCommandBufferStub(

Powered by Google App Engine
This is Rietveld 408576698