content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h - Issue 10383262: RefCounted types should not have public destructors, delegate cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h

Issue 10383262: RefCounted types should not have public destructors, delegate cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h

diff --git a/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h b/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h

index 2cabdd3071b67402c3a53c5bf253399f58101595..ba2a907c2772e6673afce2ad0beeae34805371d0 100644

--- a/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h

+++ b/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h

@@ -58,10 +58,12 @@ using WebKit::WGC3Dsizeiptr;

// context...

class WebGraphicsContext3DSwapBuffersClient {

public:

- virtual ~WebGraphicsContext3DSwapBuffersClient() { }

virtual void OnViewContextSwapBuffersPosted() = 0;

virtual void OnViewContextSwapBuffersComplete() = 0;

virtual void OnViewContextSwapBuffersAborted() = 0;

+ protected:

+ virtual ~WebGraphicsContext3DSwapBuffersClient() {}

};

class WebGraphicsContext3DErrorMessageCallback;

« no previous file with comments | « content/browser/ssl/ssl_error_handler.h ('k') | content/common/gpu/gpu_command_buffer_stub.h » ('j') | remoting/protocol/session_manager.h » ('J')