Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1731)

Unified Diff: chrome/browser/history/history.h

Issue 10383262: RefCounted types should not have public destructors, delegate cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/history/history.h
diff --git a/chrome/browser/history/history.h b/chrome/browser/history/history.h
index 1d7678947613aaad711765dc7d0774b6e54d58e3..46c56f2eddb00d0434778288f9556887af3d44be 100644
--- a/chrome/browser/history/history.h
+++ b/chrome/browser/history/history.h
@@ -249,8 +249,6 @@ class HistoryService : public CancelableRequestProvider,
// should handle this appropriately.
class URLEnumerator {
public:
- virtual ~URLEnumerator() {}
-
// Indicates that a URL is available. There will be exactly one call for
// every URL in history.
virtual void OnURL(const GURL& url) = 0;
@@ -259,6 +257,9 @@ class HistoryService : public CancelableRequestProvider,
// more callbacks made. This call is guaranteed to occur, even if there are
// no URLs. If all URLs were iterated, success will be true.
virtual void OnComplete(bool success) = 0;
+
+ protected:
+ virtual ~URLEnumerator() {}
};
// Enumerate all URLs in history. The given iterator will be owned by the

Powered by Google App Engine
This is Rietveld 408576698