chrome/browser/extensions/webstore_installer.h - Issue 10383262: RefCounted types should not have public destructors, delegate cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/webstore_installer.h

Issue 10383262: RefCounted types should not have public destructors, delegate cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/webstore_installer.h

diff --git a/chrome/browser/extensions/webstore_installer.h b/chrome/browser/extensions/webstore_installer.h

index bea6d6d692b7c33955c78c8dc6715ddbc330dd9d..4312447948f73469463f7410f6d90d91831ec317 100644

--- a/chrome/browser/extensions/webstore_installer.h

+++ b/chrome/browser/extensions/webstore_installer.h

@@ -45,6 +45,9 @@ class WebstoreInstaller : public content::NotificationObserver,

virtual void OnExtensionInstallSuccess(const std::string& id) = 0;

virtual void OnExtensionInstallFailure(const std::string& id,

const std::string& error) = 0;

+ protected:

+ virtual ~Delegate() {}

};

// Contains information about what parts of the extension install process can