Build pref-pane as universal binary on Mac OS X

Build pref-pane as universal binary on Mac OS X


BUG=125116
TEST=manual


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=142214

[Robert Sesek, 2012-05-16 14:34:03]

http://codereview.chromium.org/10383204/diff/1/remoting/host/me2me_preference...
File remoting/host/me2me_preference_pane.mm (right):

http://codereview.chromium.org/10383204/diff/1/remoting/host/me2me_preference...
remoting/host/me2me_preference_pane.mm:142: pid_t PIDForJob(const std::string&
job_label) {
http://code.google.com/codesearch#OAMlx_jo-ck/src/base/mac/launchd.h&exact_pa...

[Robert Sesek, 2012-05-16 14:37:42]

http://codereview.chromium.org/10383204/diff/1/remoting/host/me2me_preference...
File remoting/host/me2me_preference_pane.mm (right):

http://codereview.chromium.org/10383204/diff/1/remoting/host/me2me_preference...
remoting/host/me2me_preference_pane.mm:142: pid_t PIDForJob(const std::string&
job_label) {
On 2012/05/16 14:34:04, rsesek wrote:
>
http://code.google.com/codesearch#OAMlx_jo-ck/src/base/mac/launchd.h&exact_pa...

Sorry, just saw your comment. Got confused by seeing other #include "base/..."
files.

Though I thought we supported building base as 64-bit? I tried it a few weeks
ago and it worked by just setting the archs properly.

[Lambros, 2012-05-16 17:43:44]

http://codereview.chromium.org/10383204/diff/1/remoting/host/me2me_preference...
File remoting/host/me2me_preference_pane.mm (right):

http://codereview.chromium.org/10383204/diff/1/remoting/host/me2me_preference...
remoting/host/me2me_preference_pane.mm:142: pid_t PIDForJob(const std::string&
job_label) {
On 2012/05/16 14:37:43, rsesek wrote:
> On 2012/05/16 14:34:04, rsesek wrote:
> >
>
http://code.google.com/codesearch#OAMlx_jo-ck/src/base/mac/launchd.h&exact_pa...
> 
> Sorry, just saw your comment. Got confused by seeing other #include "base/..."
> files.
> 
> Though I thought we supported building base as 64-bit? I tried it a few weeks
> ago and it worked by just setting the archs properly.
mark@ told me it works, but it's currently untested and unsupported.  It's
something we want to do, but we'd have to get support from Chrome - it seems a
large change to make to Chrome, just for a small pref-pane application for
Chromoting :)

I will followup with a post to chromium-dev.  In the meantime, I welcome any
suggestions you have.

[Nico, 2012-05-16 20:22:42]

As discussed over IRC, i'll look into adding basic ARCHS support to ninja early
next week.

http://codereview.chromium.org/10383204/diff/1/remoting/remoting.gyp
File remoting/remoting.gyp (right):

http://codereview.chromium.org/10383204/diff/1/remoting/remoting.gyp#newcode415
remoting/remoting.gyp:415: 'ARCHS': ['i386', 'x86_64'],
This isn't supported in ninja yet, so it won't pass the trybots (and will break
them if you land manually)

http://codereview.chromium.org/10383204/diff/1/remoting/remoting.gyp#newcode416
remoting/remoting.gyp:416: 'GCC_ENABLE_OBJC_GC': 'supported',
ninja ignores this setting at the moment. i guess this needs to be set for
prefpanes? (i can add support for it)

[Jamie, 2012-05-16 20:31:33]

lgtm once Nico's comments are addressed. It might also be worth holding off on
this until we've had some feedback from chromium-dev about making 64-bit more
widely supported.

http://codereview.chromium.org/10383204/diff/1/remoting/host/me2me_preference...
File remoting/host/me2me_preference_pane.mm (left):

http://codereview.chromium.org/10383204/diff/1/remoting/host/me2me_preference...
remoting/host/me2me_preference_pane.mm:203: DCHECK(result);
In changing these DCHECKs, you're changing the Release-build behaviour. I think
what you have now is better, but be aware of the change.

[Lambros, 2012-05-17 18:03:29]

http://codereview.chromium.org/10383204/diff/1/remoting/remoting.gyp
File remoting/remoting.gyp (right):

http://codereview.chromium.org/10383204/diff/1/remoting/remoting.gyp#newcode415
remoting/remoting.gyp:415: 'ARCHS': ['i386', 'x86_64'],
On 2012/05/16 20:22:43, Nico wrote:
> This isn't supported in ninja yet, so it won't pass the trybots (and will
break
> them if you land manually)
OK, I'll hold off on landing the "ARCHS" change.

http://codereview.chromium.org/10383204/diff/1/remoting/remoting.gyp#newcode416
remoting/remoting.gyp:416: 'GCC_ENABLE_OBJC_GC': 'supported',
On 2012/05/16 20:22:43, Nico wrote:
> ninja ignores this setting at the moment. i guess this needs to be set for
> prefpanes? (i can add support for it)
The 64-bit prefpane needs to support GC, otherwise it triggers a "GC mismatch"
error and the System Preferences applet restarts in 32-bit mode.

[commit-bot: I haz the power, 2012-06-14 18:30:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/lambroslambrou@chromium.org/10383204/9001

[commit-bot: I haz the power, 2012-06-14 20:54:47]

Change committed as 142214