Add executable to Options interface to get the name of the executable used to execute the script.

Add executable to Options interface to get the name of the executable used to execute the script.

This is useful when you want to spawn separate dart processes. We do this from tests and we keep getting bitten by a broken search for the executable. Let's make it available instead.

R=sgjesse@google.com,iposva@google.com
BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=7382

[Søren Gjesse, 2012-05-07 14:19:56]

lgtm

I like it!

[Ivan Posva, 2012-05-07 17:40:36]

LGTM with comments.

-Ivan

https://chromiumcodereview.appspot.com/10380026/diff/1/corelib/src/implementa...
File corelib/src/implementation/options.dart (right):

https://chromiumcodereview.appspot.com/10380026/diff/1/corelib/src/implementa...
corelib/src/implementation/options.dart:28: static String _nativeExecutable =
null;
null or ""? See _nativeArguments above. When accessed they will not give you a
null access.

https://chromiumcodereview.appspot.com/10380026/diff/1/corelib/src/implementa...
corelib/src/implementation/options.dart:31: static String _nativeScript = null;
ditto.

https://chromiumcodereview.appspot.com/10380026/diff/1/corelib/src/options.dart
File corelib/src/options.dart (right):

https://chromiumcodereview.appspot.com/10380026/diff/1/corelib/src/options.da...
corelib/src/options.dart:27: * isolate.
Please comment what happens if the execution environment does not support this.
For example: "An empty string will be returned if the execution environment does
not provide access to this property."

Ditto for the other getters.

https://chromiumcodereview.appspot.com/10380026/diff/1/runtime/bin/main.cc
File runtime/bin/main.cc (right):

https://chromiumcodereview.appspot.com/10380026/diff/1/runtime/bin/main.cc#ne...
runtime/bin/main.cc:181: ++i;
i++ is more conventional, no?

[Mads Ager (google), 2012-05-08 06:39:04]

https://chromiumcodereview.appspot.com/10380026/diff/1/corelib/src/implementa...
File corelib/src/implementation/options.dart (right):

https://chromiumcodereview.appspot.com/10380026/diff/1/corelib/src/implementa...
corelib/src/implementation/options.dart:28: static String _nativeExecutable =
null;
On 2012/05/07 17:40:36, Ivan Posva wrote:
> null or ""? See _nativeArguments above. When accessed they will not give you a
> null access.

Done.

https://chromiumcodereview.appspot.com/10380026/diff/1/corelib/src/implementa...
corelib/src/implementation/options.dart:31: static String _nativeScript = null;
On 2012/05/07 17:40:36, Ivan Posva wrote:
> ditto.

Done.

https://chromiumcodereview.appspot.com/10380026/diff/1/corelib/src/options.dart
File corelib/src/options.dart (right):

https://chromiumcodereview.appspot.com/10380026/diff/1/corelib/src/options.da...
corelib/src/options.dart:27: * isolate.
On 2012/05/07 17:40:36, Ivan Posva wrote:
> Please comment what happens if the execution environment does not support
this.
> For example: "An empty string will be returned if the execution environment
does
> not provide access to this property."
> 
> Ditto for the other getters.

Done.

https://chromiumcodereview.appspot.com/10380026/diff/1/runtime/bin/main.cc
File runtime/bin/main.cc (right):

https://chromiumcodereview.appspot.com/10380026/diff/1/runtime/bin/main.cc#ne...
runtime/bin/main.cc:181: ++i;
On 2012/05/07 17:40:36, Ivan Posva wrote:
> i++ is more conventional, no?

Yes, it is. Done.

[Anders Johnsen, 2012-05-09 07:16:43]

http://codereview.chromium.org/10380026/diff/1/corelib/src/options.dart
File corelib/src/options.dart (right):

http://codereview.chromium.org/10380026/diff/1/corelib/src/options.dart#newco...
corelib/src/options.dart:27: * isolate.
Any change we could change this to always be absolute? Or maybe, return a Path
object once available?

[Mads Ager (google), 2012-05-09 07:38:09]

http://codereview.chromium.org/10380026/diff/1/corelib/src/options.dart
File corelib/src/options.dart (right):

http://codereview.chromium.org/10380026/diff/1/corelib/src/options.dart#newco...
corelib/src/options.dart:27: * isolate.
On 2012/05/09 07:16:43, ajohnsen wrote:
> Any change we could change this to always be absolute? Or maybe, return a Path
> object once available?

This is in corelib so we shouldn't have dependencies on other libraries. On the
VM (which is the only embedder who has this) you can wrap this in a File object
and you are rolling. :-)