Issue 10379024: Proper support for Uint8ClampedArray.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10379024: Proper support for Uint8ClampedArray. (Closed)

Created:
8 years, 7 months ago by Anton Muhin

Modified:
8 years, 7 months ago

Reviewers:
podivilov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Proper support for Uint8ClampedArray. R=podivilov@chromium.org TEST=dom/typed_array_{2,4}_test Committed: https://code.google.com/p/dart/source/detail?r=7364

Patch Set 2 : Better FIXME #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+322 lines, -43 lines)			Patch
M	lib/dom/dom.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	lib/dom/frog/dom_frog.dart	View		2 chunks	+92 lines, -1 line	0 comments	Download
M	lib/dom/idl/dart/dart.idl	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
M	lib/dom/scripts/generator.py	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	lib/html/dartium/html_dartium.dart	View		3 chunks	+91 lines, -1 line	0 comments	Download
M	lib/html/frog/html_frog.dart	View		2 chunks	+92 lines, -1 line	0 comments	Download
M	tests/dom/typed_arrays_2_test.dart	View		2 chunks	+31 lines, -29 lines	0 comments	Download
M	tests/dom/typed_arrays_4_test.dart	View		3 chunks	+7 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

podivilov

lgtm http://codereview.chromium.org/10379024/diff/1/lib/dom/idl/dart/dart.idl File lib/dom/idl/dart/dart.idl (right): http://codereview.chromium.org/10379024/diff/1/lib/dom/idl/dart/dart.idl#newcode18 lib/dom/idl/dart/dart.idl:18: // Ugliness ahead: we cannot analyse inheritance right ...

8 years, 7 months ago (2012-05-05 14:44:45 UTC) #2

Anton Muhin

8 years, 7 months ago (2012-05-05 14:52:28 UTC) #3

http://codereview.chromium.org/10379024/diff/1/lib/dom/idl/dart/dart.idl
File lib/dom/idl/dart/dart.idl (right):

http://codereview.chromium.org/10379024/diff/1/lib/dom/idl/dart/dart.idl#newc...
lib/dom/idl/dart/dart.idl:18: // Ugliness ahead: we cannot analyse inheritance
right now when deducing if
On 2012/05/05 14:44:45, podivilov wrote:
> Could you please add a more thorough fixme with refactoring plan for this?

Done.

Expand Messages | Collapse Messages

Issue 10379024: Proper support for Uint8ClampedArray. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Better FIXME #

Messages