Issue 10379003: enable media stream by default.

Issue 10379003: enable media stream by default. (Closed)

Created:
8 years, 7 months ago by wjia(left Chromium)

Modified:
8 years, 7 months ago

Reviewers:
jam

CC:
chromium-reviews, grt+watch_chromium.org, amit, jam, joi+watch-content_chromium.org, robertshield, darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

enable media stream by default. BUG=124790 TEST=local preview works without --enable-media-stream and remote view won't show without --enable-peer-connection. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137219

Patch Set 1 #

Patch Set 2 : add missed file #

Patch Set 3 : #

Total comments: 4

Patch Set 4 : code review, remove media stream flag from grd file #

Patch Set 5 : remove IDS_FLAGS_MEDIA_STREAM_DESCRIPTION in grd file #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -30 lines)			Patch
M	chrome/app/generated_resources.grd	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/about_flags.cc	View	1 2	1 chunk	+0 lines, -7 lines	0 comments	Download
M	chrome_frame/test/policy_settings_unittest.cc	View	1 2	2 chunks	+0 lines, -4 lines	0 comments	Download
M	content/browser/renderer_host/render_process_host_impl.cc	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/public/common/content_switches.h	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/public/common/content_switches.cc	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/renderer/render_thread_impl.cc	View	1 2	2 chunks	+1 line, -6 lines	0 comments	Download
M	content/renderer/render_view_impl.cc	View	1 2	1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

jam

http://codereview.chromium.org/10379003/diff/10001/chrome/browser/about_flags.cc File chrome/browser/about_flags.cc (left): http://codereview.chromium.org/10379003/diff/10001/chrome/browser/about_flags.cc#oldcode527 chrome/browser/about_flags.cc:527: IDS_FLAGS_MEDIA_STREAM_NAME, also remove from the grd file? http://codereview.chromium.org/10379003/diff/10001/content/renderer/render_thread_impl.cc File ...

8 years, 7 months ago (2012-05-14 06:30:11 UTC) #2

wjia(left Chromium)

code review, remove media stream flag from grd file

8 years, 7 months ago (2012-05-14 18:45:22 UTC) #3

wjia(left Chromium)

remove IDS_FLAGS_MEDIA_STREAM_DESCRIPTION in grd file

8 years, 7 months ago (2012-05-14 20:41:12 UTC) #4

wjia(left Chromium)

PTAL. http://codereview.chromium.org/10379003/diff/10001/chrome/browser/about_flags.cc File chrome/browser/about_flags.cc (left): http://codereview.chromium.org/10379003/diff/10001/chrome/browser/about_flags.cc#oldcode527 chrome/browser/about_flags.cc:527: IDS_FLAGS_MEDIA_STREAM_NAME, On 2012/05/14 06:30:11, John Abd-El-Malek wrote: > ...

8 years, 7 months ago (2012-05-14 20:42:17 UTC) #5

lgtm

Expand Messages | Collapse Messages