content/browser/web_contents/interstitial_page_impl.cc - Issue 10378089: Browser Plugin: Removed BrowserPluginWebContentsObserver (to be replaced by rewritten BrowserPlugi…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/interstitial_page_impl.cc

Issue 10378089: Browser Plugin: Removed BrowserPluginWebContentsObserver (to be replaced by rewritten BrowserPlugi… (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Default to 0 Ids in IntersitialPageImpl Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/render_view_host_impl.h ('K') | « content/browser/renderer_host/render_view_host_impl.cc ('k') | content/browser/web_contents/web_contents_impl.h » ('j') | content/browser/web_contents/web_contents_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/interstitial_page_impl.cc

diff --git a/content/browser/web_contents/interstitial_page_impl.cc b/content/browser/web_contents/interstitial_page_impl.cc

index f7a62a643817d72d7b8bf9cc2bdd418b65915606..c52e2e442b42f5400f798d16ae396d7ff6508d63 100644

--- a/content/browser/web_contents/interstitial_page_impl.cc

+++ b/content/browser/web_contents/interstitial_page_impl.cc

@@ -505,8 +505,9 @@ WebContentsView* InterstitialPageImpl::CreateWebContentsView() {

int32 max_page_id = web_contents()->

GetMaxPageIDForSiteInstance(render_view_host_->GetSiteInstance());

- render_view_host_->CreateRenderView(string16(), MSG_ROUTING_NONE,

- max_page_id);

+ render_view_host_->CreateRenderView(string16(),

+ MSG_ROUTING_NONE,

+ max_page_id, 0, 0);

Charlie Reis 2012/05/11 17:41:03 It might be more consistent with other ID schemes

Fady Samuel 2012/05/11 22:03:34 Done.

view->SetSize(web_contents_view->GetContainerSize());

// Don't show the interstitial until we have navigated to it.

view->Hide();