Browser Plugin: Removed BrowserPluginWebContentsObserver (to be replaced by rewritten BrowserPlugi…

content/browser/web_contents/interstitial_page_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/web_contents/interstitial_page_impl.h"
 
 #include <vector>
 
 #include "base/bind.h"
 #include "base/compiler_specific.h"
@@ skipping 487 matching lines @@
   if (!create_view_)
     return NULL;
   WebContentsView* web_contents_view = web_contents()->GetView();
   RenderWidgetHostView* view =
       web_contents_view->CreateViewForWidget(render_view_host_);
   render_view_host_->SetView(view);
   render_view_host_->AllowBindings(content::BINDINGS_POLICY_DOM_AUTOMATION);
 
   int32 max_page_id = web_contents()->
       GetMaxPageIDForSiteInstance(render_view_host_->GetSiteInstance());
-  render_view_host_->CreateRenderView(string16(), MSG_ROUTING_NONE,
-                                      max_page_id);
+  render_view_host_->CreateRenderView(string16(),
+                                      MSG_ROUTING_NONE,
+                                      max_page_id, 0, 0);

[Charlie Reis, 2012/05/11 17:41:03]

It might be more consistent with other ID schemes to use -1 or a constant.  For
example, the second one should be MSG_ROUTING_NONE.

[Fady Samuel, 2012/05/11 22:03:34]

Done.

   view->SetSize(web_contents_view->GetContainerSize());
   // Don't show the interstitial until we have navigated to it.
   view->Hide();
   return web_contents_view;
 }
 
 void InterstitialPageImpl::Proceed() {
   if (action_taken_ != NO_ACTION) {
     NOTREACHED();
     return;
@@ skipping 226 matching lines @@
   if (!web_contents->GetViewDelegate())
     return;
 
   web_contents->GetViewDelegate()->TakeFocus(reverse);
 }
 
 void InterstitialPageImpl::InterstitialPageRVHViewDelegate::OnFindReply(
     int request_id, int number_of_matches, const gfx::Rect& selection_rect,
     int active_match_ordinal, bool final_update) {
 }