Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: content/public/common/sandbox_init.cc

Issue 10378057: Broker out PPAPI handle duplication (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/common/sandbox_init.h ('k') | content/renderer/pepper/pepper_broker_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/common/sandbox_init.cc
===================================================================
--- content/public/common/sandbox_init.cc (revision 0)
+++ content/public/common/sandbox_init.cc (revision 0)
@@ -0,0 +1,44 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/public/common/sandbox_init.h"
+
+#if defined(OS_ANDROID)
+#include <unistd.h>
+#endif
+
+namespace content {
+
+IPC::PlatformFileForTransit BrokerGetFileHandleForProcess(
+ base::PlatformFile handle,
+ base::ProcessId target_process_id,
+ bool should_close_source) {
+ IPC::PlatformFileForTransit out_handle;
+#if defined(OS_WIN)
+ DWORD options = DUPLICATE_SAME_ACCESS;
+ if (should_close_source)
+ options |= DUPLICATE_CLOSE_SOURCE;
+ if (!content::BrokerDuplicateHandle(handle, target_process_id, &out_handle,
+ 0, options)) {
+ out_handle = IPC::InvalidPlatformFileForTransit();
+ }
+#elif defined(OS_POSIX)
+ // If asked to close the source, we can simply re-use the source fd instead of
+ // dup()ing and close()ing.
+ // When we're not closing the source, we need to duplicate the handle and take
+ // ownership of that. The reason is that this function is often used to
+ // generate IPC messages, and the handle must remain valid until it's sent to
+ // the other process from the I/O thread. Without the dup, calling code might
+ // close the source handle before the message is sent, creating a race
+ // condition.
+ int fd = should_close_source ? handle : ::dup(handle);
+ out_handle = base::FileDescriptor(fd, true);
+#else
+ #error Not implemented.
+#endif
+ return out_handle;
+}
+
+} // namespace content
+
Property changes on: content\public\common\sandbox_init.cc
___________________________________________________________________
Added: svn:eol-style
+ LF
« no previous file with comments | « content/public/common/sandbox_init.h ('k') | content/renderer/pepper/pepper_broker_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698