Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Side by Side Diff: content/public/common/sandbox_init.cc

Issue 10378057: Broker out PPAPI handle duplication (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « content/public/common/sandbox_init.h ('k') | content/renderer/pepper/pepper_broker_impl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Property Changes:
Added: svn:eol-style
+ LF
OLDNEW
(Empty)
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "content/public/common/sandbox_init.h"
6
7 #if defined(OS_ANDROID)
8 #include <unistd.h>
9 #endif
10
11 namespace content {
12
13 IPC::PlatformFileForTransit BrokerGetFileHandleForProcess(
14 base::PlatformFile handle,
15 base::ProcessId target_process_id,
16 bool should_close_source) {
17 IPC::PlatformFileForTransit out_handle;
18 #if defined(OS_WIN)
19 DWORD options = DUPLICATE_SAME_ACCESS;
20 if (should_close_source)
21 options |= DUPLICATE_CLOSE_SOURCE;
22 if (!content::BrokerDuplicateHandle(handle, target_process_id, &out_handle,
23 0, options)) {
24 out_handle = IPC::InvalidPlatformFileForTransit();
25 }
26 #elif defined(OS_POSIX)
27 // If asked to close the source, we can simply re-use the source fd instead of
28 // dup()ing and close()ing.
29 // When we're not closing the source, we need to duplicate the handle and take
30 // ownership of that. The reason is that this function is often used to
31 // generate IPC messages, and the handle must remain valid until it's sent to
32 // the other process from the I/O thread. Without the dup, calling code might
33 // close the source handle before the message is sent, creating a race
34 // condition.
35 int fd = should_close_source ? handle : ::dup(handle);
36 out_handle = base::FileDescriptor(fd, true);
37 #else
38 #error Not implemented.
39 #endif
40 return out_handle;
41 }
42
43 } // namespace content
44
OLDNEW
« no previous file with comments | « content/public/common/sandbox_init.h ('k') | content/renderer/pepper/pepper_broker_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698